Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Commit 9cbcfa9

Browse files
Update Node to v16
This matches the version in ./lib/vscode/remote/.yarnrc. I changed the engine to exactly 16 since if you use any different version it will just not work since the modules will have been built for 16 (due to the .yarnrc).
1 parent 85e8183 commit 9cbcfa9

File tree

5 files changed

+24
-24
lines changed

5 files changed

+24
-24
lines changed

‎.github/workflows/ci.yaml‎

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,10 @@ jobs:
3333
fetch-depth: 0
3434
submodules: true
3535

36-
- name: Install Node.js v14
36+
- name: Install Node.js v16
3737
uses: actions/setup-node@v3
3838
with:
39-
node-version: "14"
39+
node-version: "16"
4040

4141
- name: Install helm
4242
uses: azure/setup-helm@v2.1
@@ -74,10 +74,10 @@ jobs:
7474
fetch-depth: 0
7575
submodules: true
7676

77-
- name: Install Node.js v14
77+
- name: Install Node.js v16
7878
uses: actions/setup-node@v3
7979
with:
80-
node-version: "14"
80+
node-version: "16"
8181

8282
- name: Fetch dependencies from cache
8383
id: cache-yarn
@@ -116,10 +116,10 @@ jobs:
116116
- name: Patch Code
117117
run: quilt push -a
118118

119-
- name: Install Node.js v14
119+
- name: Install Node.js v16
120120
uses: actions/setup-node@v3
121121
with:
122-
node-version: "14"
122+
node-version: "16"
123123

124124
- name: Fetch dependencies from cache
125125
id: cache-yarn
@@ -253,10 +253,10 @@ jobs:
253253
with:
254254
fetch-depth: 0
255255

256-
- name: Install Node.js v14
256+
- name: Install Node.js v16
257257
uses: actions/setup-node@v3
258258
with:
259-
node-version: "14"
259+
node-version: "16"
260260

261261
- name: Install development tools
262262
run: |
@@ -337,18 +337,18 @@ jobs:
337337
CXX: ${{ format('{0}-g++', matrix.prefix) }}
338338
LINK: ${{ format('{0}-g++', matrix.prefix) }}
339339
NPM_CONFIG_ARCH: ${{ matrix.arch }}
340-
NODE_VERSION: v14.17.4
340+
NODE_VERSION: v16.13.0
341341

342342
steps:
343343
- name: Checkout repo
344344
uses: actions/checkout@v3
345345
with:
346346
fetch-depth: 0
347347

348-
- name: Install Node.js v14
348+
- name: Install Node.js v16
349349
uses: actions/setup-node@v3
350350
with:
351-
node-version: "14"
351+
node-version: "16"
352352

353353
- name: Install nfpm
354354
run: |
@@ -397,10 +397,10 @@ jobs:
397397
with:
398398
fetch-depth: 0
399399

400-
- name: Install Node.js v14
400+
- name: Install Node.js v16
401401
uses: actions/setup-node@v3
402402
with:
403-
node-version: "14"
403+
node-version: "16"
404404

405405
- name: Install nfpm
406406
run: |
@@ -446,10 +446,10 @@ jobs:
446446
fetch-depth: 0
447447
submodules: true
448448

449-
- name: Install Node.js v14
449+
- name: Install Node.js v16
450450
uses: actions/setup-node@v3
451451
with:
452-
node-version: "14"
452+
node-version: "16"
453453

454454
- name: Fetch dependencies from cache
455455
id: cache-yarn

‎ci/build/npm-postinstall.sh‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@ main() {
3333
echo "USE AT YOUR OWN RISK!"
3434
fi
3535

36-
if [ "$major_node_version" -ne "${FORCE_NODE_VERSION:-14}" ]; then
37-
echo "ERROR: code-server currently requires node v14."
36+
if [ "$major_node_version" -ne "${FORCE_NODE_VERSION:-16}" ]; then
37+
echo "ERROR: code-server currently requires node v16."
3838
if [ -n "$FORCE_NODE_VERSION" ]; then
3939
echo "However, you have overrided the version check to use v$FORCE_NODE_VERSION."
4040
fi

‎docs/android.md‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,11 @@ curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.0/install.sh | bash
1111
```
1212

1313
6. Exit the terminal using `exit` and then reopen the terminal
14-
7. Install and use Node.js 14:
14+
7. Install and use Node.js 16:
1515

1616
```shell
17-
nvm install 14
18-
nvm use 14
17+
nvm install 16
18+
nvm use 16
1919
```
2020

2121
8. Install code-server globally on device with: `npm i -g code-server`

‎docs/npm.md‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@ includes installing instructions based on your operating system.
2222

2323
## Node.js version
2424

25-
We use the same major version of Node.js shipped with VSCode's Electron,
26-
which is currently `14.x`. VS Code also [lists Node.js
25+
We use the same major version of Node.js shipped with Code's remote, which is
26+
currently `16.x`. VS Code also [lists Node.js
2727
requirements](https://github.com/microsoft/vscode/wiki/How-to-Contribute#prerequisites).
2828

2929
Using other versions of Node.js [may lead to unexpected
@@ -72,7 +72,7 @@ Proceed to [installing](#installing)
7272
## FreeBSD
7373

7474
```sh
75-
pkg install -y git python npm-node14 yarn-node14 pkgconf
75+
pkg install -y git python npm-node16 yarn-node16 pkgconf
7676
pkg install -y libinotify
7777
```
7878

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@
122122
"browser-ide"
123123
],
124124
"engines": {
125-
"node": ">= 14"
125+
"node": "16"
126126
},
127127
"jest": {
128128
"transform": {

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /