Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: skip docs/npm workflows on forks #4875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsjoeio merged 2 commits into main from jsjoeio-fix-workflows
Feb 22, 2022
Merged

fix: skip docs/npm workflows on forks #4875

jsjoeio merged 2 commits into main from jsjoeio-fix-workflows
Feb 22, 2022

Conversation

Copy link
Contributor

@jsjoeio jsjoeio commented Feb 16, 2022
edited
Loading

Summary

This PR adds a check to the npm and Docs Preview workflows to only run if base is coder/code-server repo. It will not run them on PRs from forks.

Changes

  • add check to preview job in docs-preview.yaml
  • add check to npm job in ci.yaml

GitHub Settings Changes

  • remove approval required for npm job

Resources:

Fixes #4027

@jsjoeio jsjoeio added docs Documentation related ci Issues related to ci chore Related to maintenance or clean up labels Feb 16, 2022
@jsjoeio jsjoeio self-assigned this Feb 16, 2022
@jsjoeio jsjoeio temporarily deployed to CI February 16, 2022 21:34 Inactive
Copy link

github-actions bot commented Feb 16, 2022
edited
Loading

✨ Coder.com for PR #4875 deployed! It will be updated on every commit.

Copy link

codecov bot commented Feb 16, 2022
edited
Loading

Codecov Report

Merging #4875 (b0fe54a) into main (d7c1894) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@
## main #4875 +/- ##
=======================================
 Coverage 69.79% 69.79% 
=======================================
 Files 29 29 
 Lines 1649 1649 
 Branches 363 363 
=======================================
 Hits 1151 1151 
 Misses 424 424 
 Partials 74 74 

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7c1894...b0fe54a. Read the comment docs.

@jsjoeio jsjoeio marked this pull request as ready for review February 16, 2022 21:52
@jsjoeio jsjoeio requested a review from a team February 16, 2022 21:52
@jsjoeio jsjoeio temporarily deployed to CI February 16, 2022 21:52 Inactive
@jsjoeio jsjoeio temporarily deployed to npm February 16, 2022 22:02 Inactive
@code-asher code-asher temporarily deployed to CI February 18, 2022 20:53 Inactive
@code-asher code-asher temporarily deployed to npm February 18, 2022 21:02 Inactive
@jsjoeio jsjoeio merged commit 23734d3 into main Feb 22, 2022
@jsjoeio jsjoeio deleted the jsjoeio-fix-workflows branch February 22, 2022 17:13
TinLe pushed a commit to TinLe/code-server that referenced this pull request Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@code-asher code-asher code-asher approved these changes

Labels
chore Related to maintenance or clean up ci Issues related to ci docs Documentation related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate changing docs preview workflow

AltStyle によって変換されたページ (->オリジナル) /