-
Notifications
You must be signed in to change notification settings - Fork 6.3k
fix: state collision #4881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: state collision #4881
Conversation
This has problems similar to the menu except instead of closing it gets re-created which interrupts the hover call and causes the test to fail. Now it will keep trying just like the menu.
039d367 to
404bee3
Compare
This contains the colliding state fix.
cea1df0 to
2dad878
Compare
Codecov Report
❗ No coverage uploaded for pull request base (
main@23734d3). Click here to learn what that means.
The diff coverage isn/a.
❗ Current head 6e0d301 differs from pull request most recent head b48cb87. Consider uploading reports for the commit b48cb87 to get more accurate results
@@ Coverage Diff @@ ## main #4881 +/- ## ======================================= Coverage ? 69.79% ======================================= Files ? 29 Lines ? 1649 Branches ? 363 ======================================= Hits ? 1151 Misses ? 424 Partials ? 74
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 23734d3...b48cb87. Read the comment docs.
Docs preview should be fixed: just waiting on a review for this 😉 #4875
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Add helper for navigating the quick picker This has problems similar to the menu except instead of closing it gets re-created which interrupts the hover call and causes the test to fail. Now it will keep trying just like the menu. * Add a test for opening a file * Add test for colliding state * Update VS Code This contains the colliding state fix.
VS Code names their databases after the workspace but if two workspaces share the same path (for example if they are on different virtual machines) but they share the same domain (since IndexedDB is scoped to domain) then those two states will have a naming collision.
Blocked on coder/vscode#46.