-
Notifications
You must be signed in to change notification settings - Fork 6.3k
feat: Add support for imagePullSecrets to Helm chart #4838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this! I think this sounds good to me but I'd like to get another opinion since I'm not a Helm expert.
Hi @WojoInc
Thanks for your contribution, looks fine for me, the only thing I would like to mention is could you please add a null value list of image pull secrets to the values file as we do for other null value objects?
This just makes it easier for people to know what is override-able by looking at the values.yaml file.
Thanks!
Matt
Codecov Report
Merging #4838 (08dbdfc) into main (c9c5c54) will not change coverage.
The diff coverage isn/a.
❗ Current head 08dbdfc differs from pull request most recent head 0cdab3d. Consider uploading reports for the commit 0cdab3d to get more accurate results
@@ Coverage Diff @@ ## main #4838 +/- ## ======================================= Coverage 69.72% 69.72% ======================================= Files 29 29 Lines 1645 1645 Branches 363 363 ======================================= Hits 1147 1147 Misses 424 424 Partials 74 74
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update c9c5c54...0cdab3d. Read the comment docs.
So the imagePullSecrets key was already in the values.yaml, so I added a short doc explaining it and an example value. Is this kinda what you were thinking @Matthew-Beckett?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, all good! Good to merge! Thanks again!
❤️
Once this is up to date, I will merge!
* add support for imagePullSecrets * Add doc and example value for imagePullSecrets * simplify syntax for imagePullSecrets Co-authored-by: Joe Previte <jjprevite@gmail.com>
Fixes #
No issue created. Fix is very minor, but I can open an issue if needed.
Adds support for
imagePullSecrets, which is defined as a top-level key in the values.yaml, but not previously used in the deployment template.This PR adds support for
imagePullSecretsinto the deployment template, which is useful for users that may need to extend the default code-server image (installing additional language support, etc.) and as such may need to pull an image from a private container registry.This should be a non-breaking change, as
imagePullSecretsis defaulted to an empty array in the values.yaml