Commit 3ad618d

somerandowjsjoeio

and

authored

feat: Add support for imagePullSecrets to Helm chart (#4838)

* add support for imagePullSecrets * Add doc and example value for imagePullSecrets * simplify syntax for imagePullSecrets Co-authored-by: Joe Previte <jjprevite@gmail.com>

1 parent c9c5c54 commit 3ad618dCopy full SHA for 3ad618d

File tree

2 files changed

-0

lines changed

ci/helm-chart
- templates
  - deployment.yaml
- values.yaml

2 files changed

-0

lines changed

`‎ci/helm-chart/templates/deployment.yaml‎`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -21,6 +21,7 @@ spec:`
`21`	`21`	`app.kubernetes.io/name: {{ include "code-server.name" . }}`
`22`	`22`	`app.kubernetes.io/instance: {{ .Release.Name }}`
`23`	`23`	`spec:`
	`24`	`+ imagePullSecrets: {{- toYaml .Values.imagePullSecrets \| nindent 8 }}`
`24`	`25`	`{{- if .Values.hostnameOverride }}`
`25`	`26`	`hostname: {{ .Values.hostnameOverride }}`
`26`	`27`	`{{- end }}`

`‎ci/helm-chart/values.yaml‎`

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,12 @@ image:`
`9`	`9`	`tag: '4.0.2'`
`10`	`10`	`pullPolicy: Always`
`11`	`11`
	`12`	`+# Specifies one or more secrets to be used when pulling images from a`
	`13`	`+# private container repository`
	`14`	`+# https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry`
`12`	`15`	`imagePullSecrets: []`
	`16`	`+# - name: registry-creds`
	`17`	`+`
`13`	`18`	`nameOverride: ""`
`14`	`19`	`fullnameOverride: ""`
`15`	`20`	`hostnameOverride: ""`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 3ad618d

File tree

2 files changed

2 files changed

`‎ci/helm-chart/templates/deployment.yaml‎`

`‎ci/helm-chart/values.yaml‎`

0 commit comments