Skip to content

chore: Update dependency requirements. Fix node version manager. #3831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

GirlBossRush merged 1 commit into main from chore-update-contributing

Jul 21, 2021

Merged

chore: Update dependency requirements. Fix node version manager. #3831

Changes from all commits

Commits

Show all changes

Select commit

chore: Update dependency requirements. Fix node version manager.

GirlBossRush Jul 20, 2021

File filter

Filter by extension

Conversations

Jump to

Jump to file

Failed to load files.

Loading

Diff view

Diff view

1 change: 1 addition & 0 deletions .node-version

Show comments View file Open in desktop

Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
	14
Copy link @jawnsy jawnsy Jul 21, 2021 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. I dunno anything about nvm, though I'm curious why these tools don't inspect package.json's engine info for this? Seems like a reasonable change to me though! jsjoeio reacted with thumbs up emoji Copy link Contributor @jsjoeio jsjoeio Jul 21, 2021 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. Agreed, you would think it would be smarter! Copy link Contributor Author @GirlBossRush GirlBossRush Jul 21, 2021 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. Ahh, open source 😆

1 change: 1 addition & 0 deletions .nvmrc

Show comments View file Open in desktop

Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
	.node-version
Copy link Contributor Author @GirlBossRush GirlBossRush Jul 21, 2021 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. Included as a symlink to avoid version drifting between NVM and nodenv jsjoeio reacted with thumbs up emoji

1 change: 1 addition & 0 deletions docs/CONTRIBUTING.md

Show comments View file Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -29,6 +29,7 @@ Here is what is needed:

		- `node` v14.x
		- `git` v2.x or greater
	- [`git-lfs`](https://git-lfs.github.com)
Copy link Contributor Author @GirlBossRush GirlBossRush Jul 21, 2021 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. I encountered a somewhat mysterious error when building the project on a clean slate. Turns out we need this too! jsjoeio reacted with thumbs up emoji
		- [`yarn`](https://classic.yarnpkg.com/en/)
		- Used to install JS packages and run scripts
		- [`nfpm`](https://classic.yarnpkg.com/en/)
Expand Down