-
Notifications
You must be signed in to change notification settings - Fork 6.3k
chore: Update dependency requirements. Fix node version manager. #3831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Included as a symlink to avoid version drifting between NVM and nodenv
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I encountered a somewhat mysterious error when building the project on a clean slate. Turns out we need this too!
@jawnsy
jawnsy
Jul 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dunno anything about nvm, though I'm curious why these tools don't inspect package.json's engine info for this?
Seems like a reasonable change to me though!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, you would think it would be smarter!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, open source 😆
Codecov Report
Merging #3831 (47999de) into main (0f45152) will not change coverage.
The diff coverage isn/a.
❗ Current head 47999de differs from pull request most recent head 709a0d0. Consider uploading reports for the commit 709a0d0 to get more accurate results
Impacted file tree graph
@@ Coverage Diff @@ ## main #3831 +/- ## ======================================= Coverage 62.05% 62.05% ======================================= Files 36 36 Lines 1863 1863 Branches 378 378 ======================================= Hits 1156 1156 Misses 601 601 Partials 106 106
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 0f45152...709a0d0. Read the comment docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work! Thanks for updating all this 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, you would think it would be smarter!
Minor note: if your PR isn't related to an issue, add the Milestone on the right side so we associate this work with the next release. I don't think it's as explicit as it should be in the docs, but more info here: https://coder.com/docs/code-server/v3.10.2/MAINTAINING#project-boards
This PR addresses some minor doc changes, and adds files that allow NVM and nodenv to automatically switch to our preferred version.