Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

feat(testing): add e2e test for 'Go Home' button #2648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsjoeio merged 23 commits into master from e2e-test-go-home
Feb 25, 2021
Merged

Conversation

Copy link
Contributor

@jsjoeio jsjoeio commented Jan 28, 2021 •
edited
Loading

This PR adds two e2e tests and makes a few modifications for testing.

Changes

  • adds a test for the login page
  • adds a test for the 'Go Home' button
  • update jest config testTimeout

Screenrecording

5029d1a9ccf52b90afb87b03f161dcde.mp4

Todos

  • fix Ci to not use container node
  • make test deterministic
  • make requested changes
  • update ignore paths for jest
  • fix .gitignore conflicts
  • fix test.sh script
  • try out setting cookie directly
  • double-check that we don't need to be setting --home
  • fix conflicts
  • update test after Vscode 1.52.1 #2543 is merged, see comment
  • refactor to promises and remove done (see comment from Anmol below)
  • address PR feedback
  • rebase
  • fix CI failures (check locally)
    • lint
    • fmt
    • release

@jsjoeio jsjoeio changed the base branch from master to add-playwright January 28, 2021 23:37
@jsjoeio jsjoeio marked this pull request as ready for review January 28, 2021 23:45
Copy link
Contributor Author

jsjoeio commented Jan 29, 2021 •
edited
Loading

Something wrong in test. Forgot the $ in the env variable in the ci script

image

Copy link
Contributor Author

jsjoeio commented Jan 29, 2021

tests are passing locally but no in CI? so weird 🤔
image

Copy link
Contributor Author

jsjoeio commented Jan 29, 2021

I'm running into strange errors 🤔

image

@jsjoeio jsjoeio marked this pull request as draft February 1, 2021 19:20
Base automatically changed from add-playwright to master February 2, 2021 18:02
@jsjoeio jsjoeio marked this pull request as ready for review February 2, 2021 22:07
@jsjoeio jsjoeio requested a review from nhooyr February 2, 2021 22:07
@jsjoeio jsjoeio marked this pull request as draft February 4, 2021 17:45
@jsjoeio jsjoeio self-assigned this Feb 4, 2021
@jsjoeio jsjoeio marked this pull request as ready for review February 4, 2021 21:59
@jsjoeio jsjoeio modified the milestones: v3.8.1, v3.8.2 Feb 5, 2021
jsjoeio and others added 17 commits February 22, 2021 13:41 
This seems to resolve a warning about a process being forcefully exited.
I think Jest provides separate console methods for each test so when the
socket tests finish Jest complains that a test keeps trying to output.
After thinking about it some more it's probably mostly only useful to
see the output when the tests are hanging. Otherwise there's a lot of
noise about Jest child processes and pipes.
@jsjoeio jsjoeio marked this pull request as ready for review February 23, 2021 00:14
@jsjoeio jsjoeio requested review from a team and code-asher and removed request for oxy and code-asher February 24, 2021 23:23
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me after this change!

@jsjoeio jsjoeio merged commit 7dbb72a into master Feb 25, 2021
@jsjoeio jsjoeio deleted the e2e-test-go-home branch February 25, 2021 18:21
@jsjoeio jsjoeio mentioned this pull request Feb 26, 2021
@jsjoeio jsjoeio added the testing Anything related to testing label May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@code-asher code-asher code-asher approved these changes

+1 more reviewer

@nhooyr nhooyr nhooyr approved these changes

Reviewers whose approvals may not affect merge requirements
Labels
testing Anything related to testing
Projects
None yet
Milestone
v3.9.1
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /