Commit 7cf71da

committed

refactor: move test functions to helpers

1 parent daac2d1 commit 7cf71daCopy full SHA for 7cf71da

File tree

+22

-24

lines changed

+22

-24

lines changed

Lines changed: 0 additions & 22 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,4 @@`
`1`	`1`	`import { logger, field } from "@coder/logger"`
`2`		`-import { Cookie } from "../../test/helpers"`
`3`	`2`
`4`	`3`	`export interface Options {`
`5`	`4`	`base: string`
`@@ -121,24 +120,3 @@ export function logError(prefix: string, err: any): void {`
`121`	`120`	logger.error(`${prefix}: ${err}`)
`122`	`121`	`}`
`123`	`122`	`}`
`124`		`-`
`125`		`-/**`
`126`		`- * Checks if a cookie exists in array of cookies`
`127`		`- */`
`128`		`-export function checkForCookie(cookies: Array<Cookie>, key: string): boolean {`
`129`		`- // Check for a cookie where the name is equal to key`
`130`		`- return Boolean(cookies.find((cookie) => cookie.name === key))`
`131`		`-}`
`132`		`-`
`133`		`-/**`
`134`		`- * Creates a login cookie if one doesn't already exist`
`135`		`- */`
`136`		`-export function createCookieIfDoesntExist(cookies: Array<Cookie>, cookieToStore: Cookie): Array<Cookie> {`
`137`		`- const cookieName = cookieToStore.name`
`138`		`- const doesCookieExist = checkForCookie(cookies, cookieName)`
`139`		`- if (!doesCookieExist) {`
`140`		`- const updatedCookies = [...cookies, cookieToStore]`
`141`		`- return updatedCookies`
`142`		`- }`
`143`		`- return cookies`
`144`		`-}`

Lines changed: 21 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -12,3 +12,24 @@ export interface Cookie {`
`12`	`12`	`secure: boolean`
`13`	`13`	`sameSite: "Strict" \| "Lax" \| "None"`
`14`	`14`	`}`
	`15`	`+`
	`16`	`+/**`
	`17`	`+ * Checks if a cookie exists in array of cookies`
	`18`	`+ */`
	`19`	`+export function checkForCookie(cookies: Array<Cookie>, key: string): boolean {`
	`20`	`+ // Check for a cookie where the name is equal to key`
	`21`	`+ return Boolean(cookies.find((cookie) => cookie.name === key))`
	`22`	`+}`
	`23`	`+`
	`24`	`+/**`
	`25`	`+ * Creates a login cookie if one doesn't already exist`
	`26`	`+ */`
	`27`	`+export function createCookieIfDoesntExist(cookies: Array<Cookie>, cookieToStore: Cookie): Array<Cookie> {`
	`28`	`+ const cookieName = cookieToStore.name`
	`29`	`+ const doesCookieExist = checkForCookie(cookies, cookieName)`
	`30`	`+ if (!doesCookieExist) {`
	`31`	`+ const updatedCookies = [...cookies, cookieToStore]`
	`32`	`+ return updatedCookies`
	`33`	`+ }`
	`34`	`+ return cookies`
	`35`	`+}`

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -13,13 +13,12 @@ import {`
`13`	`13`	`resolveBase,`
`14`	`14`	`split,`
`15`	`15`	`trimSlashes,`
`16`		`- checkForCookie,`
`17`		`- createCookieIfDoesntExist,`
`18`	`16`	`normalize,`
`19`	`17`	`} from "../src/common/util"`
`20`	`18`	`import { Cookie as CookieEnum } from "../src/node/routes/login"`
`21`	`19`	`import { hash } from "../src/node/util"`
`22`	`20`	`import { PASSWORD } from "./constants"`
	`21`	`+import { checkForCookie, createCookieIfDoesntExist } from "./helpers"`
`23`	`22`
`24`	`23`	`const dom = new JSDOM()`
`25`	`24`	`global.document = dom.window.document`

Comments

(0)