Skip to content

feat: expose the sign and verbose runtime parameters as helm variables #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

code-asher merged 2 commits into main from feat/helm_expose_sign_and_logging_params

Sep 8, 2025

Merged

feat: expose the sign and verbose runtime parameters as helm variables #117

Changes from all commits

Commits

Show all changes

Select commit Hold shift + click to select a range

expose the sign and verbose runtime parameters as helm vars

rowansmithau Sep 8, 2025

changelog entry

rowansmithau Sep 8, 2025

File filter

Filter by extension

Conversations

Jump to

Jump to file

Failed to load files.

Loading

Diff view

Diff view

2 changes: 2 additions & 0 deletions CHANGELOG.md

Show comments View file Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -7,6 +7,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

		## Unreleased

	- Expose the `--verbose` and `--sign` runtime parameters as Helm variables.

		## [2.4.0](https://github.com/coder/code-marketplace/releases/tag/v2.4.0) - 2025年09月04日

		### Added
Expand Down

6 changes: 6 additions & 0 deletions helm/templates/deployment.yaml

Show comments View file Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -70,6 +70,12 @@ spec:
		{{- else }}
		- --extensions-dir
		- /extensions
	{{- if .Values.verboseLogging }}
	- --verbose
	{{- end }}
	{{- if .Values.extensionSigning }}
	- --sign
	{{- end }}
		{{- end }}
		{{- if or (.Values.volumeMounts) (not .Values.persistence.artifactory.enabled) }}
		volumeMounts:
Expand Down

6 changes: 6 additions & 0 deletions helm/values.yaml

Show comments View file Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -12,6 +12,12 @@ image:

		extraEnv: []

	# Enables the `--verbose` command parameter to enable debug level logging.
	verboseLogging: false

	# Enables code-marketplace to add empty signatures to extensions per https://github.com/coder/code-marketplace/pull/84
	extensionSigning: false

		imagePullSecrets: []
		nameOverride: ""
		fullnameOverride: ""
Expand Down

Loading