Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

feat: expose the sign and verbose runtime parameters as helm variables #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
code-asher merged 2 commits into main from feat/helm_expose_sign_and_logging_params
Sep 8, 2025

Conversation

Copy link
Contributor

@rowansmithau rowansmithau commented Sep 8, 2025

Per Slack discussion this PR allows folks who deploy to Kubernetes to make use of the --verbose and --sign runtime parameters so they don't have to manually edit the template pre/post deployment.

Both are opt in and disabled by default in order to not change existing behaviour.

➜ helm git:(feat/helm_expose_sign_and_logging_params) helm template -n code-marketplace --create-namespace code-marketplace . --set verboseLogging=true --set extensionSigning=true
....
# Source: code-marketplace/templates/deployment.yaml
apiVersion: apps/v1
kind: Deployment
....
 args:
 - --address
 - "0.0.0.0:80"
 - --extensions-dir
 - /extensions
 - --verbose
 - --sign
 volumeMounts:

➜ helm git:(feat/helm_expose_sign_and_logging_params) helm template -n code-marketplace --create-namespace code-marketplace .
....
 args:
 - --address
 - "0.0.0.0:80"
 - --extensions-dir
 - /extensions
 volumeMounts:

Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks!

@code-asher code-asher merged commit 1c3a19e into main Sep 8, 2025
2 checks passed
@code-asher code-asher deleted the feat/helm_expose_sign_and_logging_params branch September 8, 2025 17:19
@github-actions github-actions bot locked and limited conversation to collaborators Sep 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@code-asher code-asher code-asher approved these changes

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /