-
Notifications
You must be signed in to change notification settings - Fork 78
feat: add option to control behavior when rejecting new file diffs #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ThomasK33
merged 1 commit into
main
from
thomask33/feat_add_on_new_file_reject_option_to_control_empty_buffer_behavior
Sep 10, 2025
Merged
feat: add option to control behavior when rejecting new file diffs #114
ThomasK33
merged 1 commit into
main
from
thomask33/feat_add_on_new_file_reject_option_to_control_empty_buffer_behavior
Sep 10, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- feat: add focus_after_send option for terminal behavior #118 Graphite
- feat: add working directory control for Claude terminal #117 Graphite
- feat: add Shift+Enter keybinding for new line in terminal #116 Graphite
- feat: add PartialClaudeCodeConfig type for better configuration handling #115 Graphite
- feat: add option to control behavior when rejecting new file diffs #114 Graphite 👈 (View in Graphite)
- feat: redesign diff view with horizontal layout and new tab options #111 Graphite
- feat: add Claude Haiku model and update type annotations #110 Graphite
main
This stack of pull requests is managed by Graphite. Learn more about stacking.
This was referenced Aug 8, 2025
This was referenced Aug 8, 2025
@ThomasK33
ThomasK33
force-pushed
the
thomask33/feat_add_on_new_file_reject_option_to_control_empty_buffer_behavior
branch
from
August 8, 2025 14:18
44647fb
to
b350b53
Compare
@ThomasK33
ThomasK33
force-pushed
the
thomask33/feat_redesign_diff_view_with_horizontal_layout_and_new_tab_options
branch
2 times, most recently
from
August 8, 2025 19:34
7ab50da
to
f8c7db8
Compare
@ThomasK33
ThomasK33
force-pushed
the
thomask33/feat_add_on_new_file_reject_option_to_control_empty_buffer_behavior
branch
from
August 8, 2025 19:34
b350b53
to
0bcb677
Compare
@ThomasK33
ThomasK33
force-pushed
the
thomask33/feat_redesign_diff_view_with_horizontal_layout_and_new_tab_options
branch
from
August 10, 2025 16:22
f8c7db8
to
763ee39
Compare
@ThomasK33
ThomasK33
force-pushed
the
thomask33/feat_add_on_new_file_reject_option_to_control_empty_buffer_behavior
branch
from
August 10, 2025 16:22
0bcb677
to
00cc3d9
Compare
@ThomasK33
ThomasK33
force-pushed
the
thomask33/feat_add_on_new_file_reject_option_to_control_empty_buffer_behavior
branch
from
September 3, 2025 15:16
00cc3d9
to
fbe5b80
Compare
@ThomasK33
ThomasK33
force-pushed
the
thomask33/feat_redesign_diff_view_with_horizontal_layout_and_new_tab_options
branch
from
September 3, 2025 15:16
763ee39
to
8879ae0
Compare
Merge activity
- Sep 10, 3:36 PM UTC: A user started a stack merge that includes this pull request via Graphite.
- Sep 10, 3:38 PM UTC: Graphite rebased this pull request as part of a merge.
- Sep 10, 3:38 PM UTC: @ThomasK33 merged this pull request with Graphite.
@ThomasK33
ThomasK33
changed the base branch from
thomask33/feat_redesign_diff_view_with_horizontal_layout_and_new_tab_options
to
graphite-base/114
September 10, 2025 15:36
@ThomasK33
ThomasK33
changed the base branch from
graphite-base/114
to
main
September 10, 2025 15:36
Change-Id: Idc973b23ff2a00ce2e9142e8c2b941b114ef7059 Signed-off-by: Thomas Kosiewski <tk@coder.com>
@ThomasK33
ThomasK33
force-pushed
the
thomask33/feat_add_on_new_file_reject_option_to_control_empty_buffer_behavior
branch
from
September 10, 2025 15:37
fbe5b80
to
990fe27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option to control behavior when rejecting new file diffs
This PR adds a new configuration option
on_new_file_reject
that controls what happens when a user rejects a diff for a new file:keep_empty
(default): Leaves the empty buffer in placeclose_window
: Closes the placeholder split windowPreviously, when rejecting a new file diff, the plugin would always try to delete the original buffer. This could cause issues when the buffer was reused from an existing empty buffer, leading to potential crashes when attempting to reopen a diff.
The PR includes:
config.lua
with validationtypes.lua
diff.lua
to track whether the original buffer was created by the pluginThis change improves stability when working with new files and gives users more control over the UI behavior.