-
Notifications
You must be signed in to change notification settings - Fork 65
Fix rendering problem with a superscript bigger than 10 #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is #37.
You set up the rust toolchain correctly(https://github.com/clearloop/leetcode-cli/blob/master/rust-toolchain#L1)
However, the following workflows invoke rustc 1.54.0-nightly (35fff69d0 2021年06月06日) instead of rustc 1.54.0-nightly (8cf990c9b 2021年05月15日)
- https://github.com/clearloop/leetcode-cli/blob/master/.github/workflows/rust.yml#L21
- https://github.com/clearloop/leetcode-cli/blob/master/.github/workflows/clippy.yml#L21
There are two possible fixes.
- Make workflow files explicitly use
nightly-2021年05月16日 - Fix cannot find type
NoneErrorin modulestd::option#37
I committed the first fix.
Thanks!! @heeh! just published v0.3.7 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
The issue #38 is caused by the code at helper.rs#L126
superscript(n / 10).parse().unwrap_or(0)andsuperscript(n % 10).parse().unwrap_or(0)always fail.parsefunction does not know the output type. It fails and we get0instead of31as in leetcode pick: wrong constraints #38 .parse::<u32>(), parsing a superscript(e.g.3) producesinvalid digit error.I believe that you want to concatenate two superscripts here.
This commit produces a valid representation.
ex)
-231 <= num <= 231 - 1