Feat: like vsc-leetcode-cli use @lc code=start and @lc code=end to pick the code #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

clearloop merged 12 commits into clearloop:master from wendajiang:dev

Jul 9, 2022

Merged

Feat: like vsc-leetcode-cli use @lc code=start and @lc code=end to pick the code #77

clearloop merged 12 commits into clearloop:master from wendajiang:dev

Jul 9, 2022

Conversation

wendajiang

Copy link

Collaborator

@wendajiang wendajiang commented Jul 3, 2022

edit add file include extra information
remove test file, and use memory all_cases
use scraper crate parser the desc html fragment

Besides, as I do not like auto create test file in the workspace, so this PR use Draft. And if someone need the @lc code=start feature, we can discuss how to merge to master.

PS. @lc code=start almost use for me to auto-completion code like this

#include <bits/stdc++.h>
using namespace std;
// @lc code=start
class Solution {
 public:
 vector<int> twoSum(vector<int>& nums, int target) {
 vector<int> result;
 unordered_map<int, int> mapping;
 for (int i = 0; i < nums.size(); i++) {
 mapping[nums[i]] = i;
 }
 for (int i = 0; i < nums.size(); i++) {
 int searched = target - nums[i];
 if (mapping.find(searched) != mapping.end() &&
 i != mapping[searched]) {
 result.push_back(i);
 result.push_back(mapping[searched]);
 break;
 }
 }
 return result;
 }
};
// @lc code=end

so that, when exec problem, only upload the content between @lc code = start and @lc code=end

wendajiang added 2 commits

July 2, 2022 22:23

@wendajiang


 fix: clippy warning for rust 1.61 stable

3c7c5c6

@wendajiang


 feat: upgrade dep version, and use Rust 2021 Edition

925e0fa

@clearloop

Copy link

Owner

clearloop commented Jul 4, 2022 •

edited

Loading

thx!! @wendajiang

Besides, as I do not like auto create test file in the workspace, so this PR use Draft. And if someone need the @lc code=start feature, we can discuss how to merge to master.

Understand this concern, due to some users like to review their past code, I think we can add a flag to keep it? how do you think about the flag?

@wendajiang

Copy link

Collaborator Author

wendajiang commented Jul 4, 2022

thx!! @wendajiang

Besides, as I do not like auto create test file in the workspace, so this PR use Draft. And if someone need the @lc code=start feature, we can discuss how to merge to master.

Understand this concern, due to some users like to review their past code, I think we can add a flag to keep it? how do you think about the flag?

So do I, I would recover test file feature by default closing this weekend.

@wendajiang


 Merge branch 'clearloop:master' into master

894c50b

@clearloop

Copy link

Owner

clearloop commented Jul 4, 2022

So do I, I would recover test file feature by default closing this weekend.

Yeah and mb we can configure this in our config.toml, if need the test files

wendajiang added 8 commits

July 8, 2022 20:11

@wendajiang


 feat: remove test file

38b823c

@wendajiang


 fix: replace deprecated is_present

82cbf31

@wendajiang


 feat: use scraper to parser html fragment

210d772

@wendajiang


 feat: like vsc-leetcode-cli edit file has extra problem desc

1. edit add file include extra information
2. remove test file, and use memory all_cases
3. use scraper crate parser the desc html fragment

@wendajiang


 fix: solve issue 72

6a23c18

@wendajiang


 not use deprecated code

f47b7c8

@wendajiang


 revert: use generate the test file

5d7a82e

@wendajiang


 feat: storage config path use the absolutely dir, not in the root config

371548c

@wendajiang

Copy link

Collaborator Author

wendajiang commented Jul 8, 2022

So do I, I would recover test file feature by default closing this weekend.

Yeah and mb we can configure this in our config.toml, if need the test files

When i re-add the test file feature, I find the test file path use the code path, as i think it's ok, so re-use the config.
However, I change the code path in config file to absolute path that not use the root dir(distinguish the scripts and the problem db path).

And I do not add new config for opening/closing the test file, as I use edit subcommand arg like leetcode edit -t to detect generate the test case file or not.

And above all is finished.

@wendajiang


 fix: fmt fix

8fed4a6

@clearloop clearloop merged commit 5566870 into clearloop:master

Jul 9, 2022

@clearloop clearloop mentioned this pull request

Jul 12, 2022

Flaws in version 0.3.12 #80

Closed

clearloop

clearloop reviewed

Jul 12, 2022

View reviewed changes

src/cmds/edit.rs

Comment on lines +25 to +26

pub const CODE_START: &str = r#"// @lc code=start"#;

pub const CODE_END: &str = r#"// @lc code=end"#;

Copy link

Owner

@clearloop clearloop Jul 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shoud configure these in the config, the // can not be recognized by every programming languages

Copy link

Collaborator Author

@wendajiang wendajiang Jul 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, you are right, // maybe wrong!

clearloop

clearloop reviewed

Jul 12, 2022

View reviewed changes

src/helper.rs

Comment on lines -114 to -129

pub fn superscript(n: u8) -> String {

match n {

x if x >= 10 => format!("{}{}", superscript(n / 10), superscript(n % 10)),

0 => "0".to_string(),

1 => "1".to_string(),

2 => "2".to_string(),

3 => "3".to_string(),

4 => "4".to_string(),

5 => "5".to_string(),

6 => "6".to_string(),

7 => "7".to_string(),

8 => "8".to_string(),

9 => "9".to_string(),

_ => n.to_string(),

}

Copy link

Owner

@clearloop clearloop Jul 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz check if scrapper can support this

Copy link

Collaborator Author

@wendajiang wendajiang Jul 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

however, I do not think is nessesary, and this relpace use ^ and _, if you think this must be use the utf-8 character, I can do some manual work to recover this. :)

Copy link

Owner

@clearloop clearloop Jul 12, 2022 •

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these optimizations are from #12 and #39, we better to keep these for respecting the previous contributors, btw, I think there is a escraper in our crate also lol #11

Labels

None yet

2 participants

@wendajiang @clearloop

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Feat: like vsc-leetcode-cli use @lc code=start and @lc code=end to pick the code #77

Feat: like vsc-leetcode-cli use @lc code=start and @lc code=end to pick the code #77

Uh oh!

Conversation

@wendajiang wendajiang commented Jul 3, 2022

Uh oh!

clearloop commented Jul 4, 2022 •

edited

Loading

Uh oh!

Uh oh!

wendajiang commented Jul 4, 2022

Uh oh!

clearloop commented Jul 4, 2022

Uh oh!

wendajiang commented Jul 8, 2022

Uh oh!

@clearloop clearloop Jul 12, 2022

Choose a reason for hiding this comment

Uh oh!

@wendajiang wendajiang Jul 12, 2022

Choose a reason for hiding this comment

Uh oh!

@clearloop clearloop Jul 12, 2022

Choose a reason for hiding this comment

Uh oh!

@wendajiang wendajiang Jul 12, 2022

Choose a reason for hiding this comment

Uh oh!

@clearloop clearloop Jul 12, 2022 •

edited

Loading

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Feat: like vsc-leetcode-cli use @lc code=start and @lc code=end to pick the code #77

Feat: like vsc-leetcode-cli use @lc code=start and @lc code=end to pick the code #77

Uh oh!

Conversation

@wendajiang wendajiang commented Jul 3, 2022

Uh oh!

clearloop commented Jul 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wendajiang commented Jul 4, 2022

Uh oh!

clearloop commented Jul 4, 2022

Uh oh!

wendajiang commented Jul 8, 2022

Uh oh!

@clearloop clearloop Jul 12, 2022

Choose a reason for hiding this comment

Uh oh!

@wendajiang wendajiang Jul 12, 2022

Choose a reason for hiding this comment

Uh oh!

@clearloop clearloop Jul 12, 2022

Choose a reason for hiding this comment

Uh oh!

@wendajiang wendajiang Jul 12, 2022

Choose a reason for hiding this comment

Uh oh!

@clearloop clearloop Jul 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

clearloop commented Jul 4, 2022 •

edited

Loading

@clearloop clearloop Jul 12, 2022 •

edited

Loading