Skip to content

test: Replace dead row length check with similar shape check #3532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

charmander merged 1 commit into brianc:master from charmander:test-dead-code

Aug 22, 2025

Merged

test: Replace dead row length check with similar shape check #3532

Changes from all commits

Commits

Show all changes

Select commit

test: Replace dead row length check with similar shape check

charmander Aug 22, 2025

File filter

Filter by extension

Conversations

Jump to

Jump to file

Failed to load files.

Loading

Diff view

Diff view

11 changes: 2 additions & 9 deletions packages/pg/test/integration/client/simple-query-tests.js

Show comments View file Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -19,15 +19,8 @@ test('simple query interface', function () {
		rows.push(row['name'])
		})
		query.once('row', function (row) {
	test('Can iterate through columns', function () {
	const columnCount = Object.keys(row).length
	if ('length' in row) {
	assert.lengthIs(
	row,
	columnCount,
	'Iterating through the columns gives a different length from calling .length.'
	)
	}
	test('returned right columns', function () {
	assert.deepStrictEqual(row, { name: row.name })
		})
		})

Expand Down