-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
test: Replace dead row length check with similar shape check #3532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These object-mode rows don’t include a `length`. Dead code since 721cf56 ("Rows are now associative arrays rather than straight arrays.")?
@charmander
charmander
force-pushed
the
test-dead-code
branch
from
August 22, 2025 01:09
6e0d85b to
3677c2a
Compare
@charmander
charmander
changed the title
(削除) cleanup: Replace dead code in test (削除ここまで)
(追記) test: Replace dead row length check with similar shape check (追記ここまで)
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
These object-mode rows don’t include a
length. Dead code since 721cf56 ("Rows are now associative arrays rather than straight arrays.")?