-
Notifications
You must be signed in to change notification settings - Fork 4.2k
fix(relay): add a retry hint when shared admission is unavailable - #7405
Open
frahlg wants to merge 1 commit into
Open
fix(relay): add a retry hint when shared admission is unavailable #7405frahlg wants to merge 1 commit into
frahlg wants to merge 1 commit into
Conversation
Signed-off-by: Fredrik Ahlgren <fredrik@sourceful-labs.com>
🔐 Codex Security Review
Status: review required for the current range.
The current range is
3c7f288c60d67df78577b237e27c3dfc8831aaa1...2f9550a90d66d4a3de576484162b07aebb1a3be8.
A new review must complete for this exact range. When manual authorization
is required, a Block organization member must comment exactly
@buzz-security-review 2f9550a90d66d4a3de576484162b07aebb1a3be8to authorize a new review.
Any previous review applies only to its recorded range.
This was referenced Sep 6, 2026
frahlg
marked this pull request as ready for review
September 6, 2026 05:58
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
i️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
When Redis admission fails, the relay sends
rate-limited: shared admission unavailablewithout a retry hint. Mobile treats a rate-limited CLOSED with no hint as a ten-second session-wide gate, even if the Redis failure was brief.Add
retry in 1sto this WebSocket rejection. This is a retry delay, not a claim that Redis will recover within a second. Admission still fails closed, configured quota resets keep their existing hints, and EVENT/REQ/COUNT rejections keep their existing correlation fields. HTTP responses do not change.The three regression assertions drive
enforce_ws_admissionwith deliberately unreachable Redis and inspect the actual outbound EVENT, REQ, and COUNT responses. All three failed before the production change. All seven rejection tests pass after it.Validation beyond the seven rejection tests:
just cipassed on a local checkout combining this PR, fix(mobile): close retired relay handshakes #7386 , and perf(mobile): parallelize independent channel startup reads #7397 .just testremains red atbuzz-db::observability_source::p0_pool_acquisitions_use_typed_operation_pairs_without_other, which reportsevent production path bypasses operation attribution with .fetch_all(pool). The same test fails with the same message from an untouched archive of base commitf038cbbb0. This PR changes none of its source inputs. That failure stops the combined integration run before later packages, so the relay tests above ran separately.