-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Open
Conversation
Signed-off-by: Fredrik Ahlgren <fredrik@sourceful-labs.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
i️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🔐 Codex Security Review
Status: review required for the current range.
The current range is
3c7f288c60d67df78577b237e27c3dfc8831aaa1...bf877a001e40d4ce69db698ac039e37728f37770.
A new review must complete for this exact range. When manual authorization
is required, a Block organization member must comment exactly
@buzz-security-review bf877a001e40d4ce69db698ac039e37728f37770to authorize a new review.
Any previous review applies only to its recorded range.
Signed-off-by: Fredrik Ahlgren <fredrik@sourceful-labs.com>
This was referenced Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
When a network or provider change retires a relay connection before the WebSocket upgrade completes, the pending HTTP transport stays open.
disconnect()can also wait forever on a channel sink that has no WebSocket yet. A late completion can overwrite a replacement attempt's state.Give each handshake its own HTTP client, close it when the attempt ends, and check attempt identity before reporting a failure or starting authentication. Skip the WebSocket close wait while the transport is still connecting. If cancellation races with a completed upgrade, close that retired WebSocket too. Active connections keep the existing authentication and ping behavior.
This complements #4826, which adds a handshake deadline. It does not add another deadline or change reconnect backoff. The settings widget tests now stub the relay session instead of opening real sockets.
Validation:
disconnect,dispose, peer closure, replacement attempts, cancellation after upgrade, and healthy/silent upgraded peers. The stalled-disposal and completed-upgrade regressions failed before their respective fixes.just mobile-checkpassed after the final change.just cipassed on a local checkout combining this PR, perf(mobile): parallelize independent channel startup reads #7397 , and fix(relay): add a retry hint when shared admission is unavailable #7405 . That run passed all 2,077 mobile tests and 3,165 desktop Tauri tests (19 ignored). The earlier unrelated Codex-adapter test failure did not recur.I have not measured this change on a physical iPhone. It fixes connection cleanup; it does not claim a measured cold-start improvement.