-
Notifications
You must be signed in to change notification settings - Fork 136
Fix compilation #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix compilation #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skovhus
skovhus
commented
Apr 1, 2018
@@ -14,6 +14,9 @@
"sourceMap": true
},
"exclude": [
"node_modules"
"node_modules",
"**/__tests__/*",
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By adding these the compilation path is as before server/out/server.js
FYI @mads-hartmann
@skovhus Awesome, I love the reinstall-server improvement to the workflow 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When introducing the integration tests (#14) I broke the build.
The TypeScript compilers output path depends magically on the files in the source directory. So when introducing new test setup files, the compilation path was suddenly
server/out/server/server.jsinstead ofserver/out/server.js.The main problem here is that we don't clean the compilation directories... As I tested that it worked after introducing integration tests, but the old files were still in my local copy of
out.This PR: