-
Notifications
You must be signed in to change notification settings - Fork 136
WIP: A bit of refactoring #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is great :) Before refactoring too much more please have a look at my branch completions-based-on-your-PATH where I also did some refactoring while trying to add more completions :) I'm happy to merge your two PRs tonight and then try to get my PR in a state where you can review it if you're up for that :)
Before refactoring too much more please have a look at my branch
Ah, see you did some more since last time I looked. 👍👍 I hope the new tests will help you with the refactoring you are doing...
can review it if you're up for that
I'm up for that. : )
Feel free to ignore this PR if there are too many conflicts merging this. : )
WIP: Depends on #15
To get into the codebase, I did a few refactorings and documentation fixes for the server and client.
@mads-hartmann Let me know if you think the flatten functions makes sense to you.