Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

updated schematic [MKC-514] #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jhansson-ard merged 7 commits into main from jhansson-ard/tonepitchfollowsche
Jun 28, 2022
Merged

Conversation

Copy link
Contributor

@jhansson-ard jhansson-ard commented Jun 27, 2022

What This PR Changes

Schematic was wrong according to the wire-diagram

This PR updates the schematic as well as a minor wire-move on the wire-diagram.
From this issue: #306

Contribution Guidelines

jhansson-ard and others added 3 commits June 27, 2022 13:36
updated circuit
Co-Authored-By: Brian Cook <1450040+Coding-Badly@users.noreply.github.com>
@jhansson-ard jhansson-ard added bug Something isn't working community Bugs and fixes suggested by the community arduino Bugs and fixes added by the Arduino Team labels Jun 27, 2022
@jhansson-ard jhansson-ard linked an issue Jun 27, 2022 that may be closed by this pull request
Copy link

gatsby-cloud bot commented Jun 27, 2022
edited
Loading

Gatsby Cloud Build Report

docs-content

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 8m

Copy link
Member

@marqdevx marqdevx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

You mean the position right? f2708c5

Copy link
Contributor

@Coding-Badly Coding-Badly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please place the blue wire termination in the correct location.

image

marqdevx reacted with rocket emoji
@jhansson-ard jhansson-ard deleted the jhansson-ard/tonepitchfollowsche branch June 28, 2022 09:08
Copy link
Contributor Author

@Coding-Badly I'm sorry, I didn't see your comment in time. I will fix this now ⭐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marqdevx marqdevx marqdevx approved these changes

+1 more reviewer

@Coding-Badly Coding-Badly Coding-Badly requested changes

Reviewers whose approvals may not affect merge requirements
Labels
arduino Bugs and fixes added by the Arduino Team bug Something isn't working community Bugs and fixes suggested by the community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect schematic / diagram

AltStyle によって変換されたページ (->オリジナル) /