-
-
Notifications
You must be signed in to change notification settings - Fork 553
feat: updates installs libraries dependencies by default #2830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+18
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@giacomocusinato
giacomocusinato
temporarily deployed
to
production
December 11, 2025 14:55 — with
GitHub Actions
Inactive
@giacomocusinato
giacomocusinato
changed the title
(削除) #2505 (削除ここまで)
(追記) feat: updates installs libraries dependencies by default (追記ここまで)
Dec 11, 2025
@giacomocusinato
giacomocusinato
force-pushed
the
#2505
branch
from
December 11, 2025 14:58
384af87 to
c8121cc
Compare
@giacomocusinato
giacomocusinato
temporarily deployed
to
production
December 11, 2025 14:58 — with
GitHub Actions
Inactive
@giacomocusinato
giacomocusinato
force-pushed
the
#2505
branch
from
December 11, 2025 15:40
c8121cc to
96e5eae
Compare
@giacomocusinato
giacomocusinato
temporarily deployed
to
production
December 11, 2025 15:40 — with
GitHub Actions
Inactive
@giacomocusinato
giacomocusinato
temporarily deployed
to
production
December 11, 2025 16:10 — with
GitHub Actions
Inactive
@giacomocusinato
giacomocusinato
force-pushed
the
#2505
branch
from
December 15, 2025 08:39
96e5eae to
d3f2e3e
Compare
@giacomocusinato
giacomocusinato
temporarily deployed
to
production
December 15, 2025 08:40 — with
GitHub Actions
Inactive
csarnataro
csarnataro
approved these changes
Dec 16, 2025
Collaborator
@csarnataro
csarnataro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@giacomocusinato
giacomocusinato
merged commit Dec 16, 2025
93834a6
into
main
40 of 41 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Resolves #2505
Change description
libraryService.installnow automatically installs all required dependencies for a selected library by default.If the user explicitly chooses the "Install without dependencies" option, the installation proceeds without pulling additional libraries.
Other information
Reviewer checklist