Commit 93834a6

authored

feat: service installs library dependencies by default (#2830)

1 parent 46f1d7c commit 93834a6Copy full SHA for 93834a6

File tree

+18

-21

lines changed

+18

-21

lines changed

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,6 @@ export class FirstStartupInstaller extends Contribution {`
`61`	`61`	`try {`
`62`	`62`	`await this.libraryService.install({`
`63`	`63`	`item: builtInLibrary,`
`64`		`- installDependencies: true,`
`65`	`64`	`noOverwrite: true, // We don't want to automatically replace custom libraries the user might already have in place`
`66`	`65`	`installLocation: LibraryLocation.BUILTIN,`
`67`	`66`	`});`

Lines changed: 15 additions & 17 deletions

Original file line number	Diff line number	Diff line change
`@@ -167,23 +167,21 @@ export class LibraryListWidget extends ListWidget<`
`167`	`167`	`installDependencies = false;`
`168`	`168`	`}`
`169`	`169`
`170`		`- if (typeof installDependencies === 'boolean') {`
`171`		`- await this.service.install({`
`172`		`- item,`
`173`		`- version,`
`174`		`- progressId,`
`175`		`- installDependencies,`
`176`		`- });`
`177`		`- this.messageService.info(`
`178`		`- nls.localize(`
`179`		`- 'arduino/library/installedSuccessfully',`
`180`		`- 'Successfully installed library {0}:{1}',`
`181`		`- item.name,`
`182`		`- version`
`183`		`- ),`
`184`		`- { timeout: 3000 }`
`185`		`- );`
`186`		`- }`
	`170`	`+ await this.service.install({`
	`171`	`+ item,`
	`172`	`+ version,`
	`173`	`+ progressId,`
	`174`	`+ noDeps: !installDependencies,`
	`175`	`+ });`
	`176`	`+ this.messageService.info(`
	`177`	`+ nls.localize(`
	`178`	`+ 'arduino/library/installedSuccessfully',`
	`179`	`+ 'Successfully installed library {0}:{1}',`
	`180`	`+ item.name,`
	`181`	`+ version`
	`182`	`+ ),`
	`183`	`+ { timeout: 3000 }`
	`184`	`+ );`
`187`	`185`	`}`
`188`	`186`
`189`	`187`	`protected override async uninstall({`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ export interface LibraryService`
`27`	`27`	`item: LibraryPackage;`
`28`	`28`	`progressId?: string;`
`29`	`29`	`version?: Installable.Version;`
`30`		`- installDependencies?: boolean;`
	`30`	`+ noDeps?: boolean;`
`31`	`31`	`noOverwrite?: boolean;`
`32`	`32`	`installLocation?: LibraryLocation.BUILTIN \| LibraryLocation.USER;`
`33`	`33`	`}): Promise<void>;`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -306,7 +306,7 @@ export class LibraryServiceImpl`
`306`	`306`	`item: LibraryPackage;`
`307`	`307`	`progressId?: string;`
`308`	`308`	`version?: Installable.Version;`
`309`		`- installDependencies?: boolean;`
	`309`	`+ noDeps?: boolean;`
`310`	`310`	`noOverwrite?: boolean;`
`311`	`311`	`installLocation?: LibraryLocation.BUILTIN \| LibraryLocation.USER;`
`312`	`312`	`}): Promise<void> {`
`@@ -321,7 +321,7 @@ export class LibraryServiceImpl`
`321`	`321`	`req.setInstance(instance);`
`322`	`322`	`req.setName(item.name);`
`323`	`323`	`req.setVersion(version);`
`324`		`- req.setNoDeps(!options.installDependencies);`
	`324`	`+ req.setNoDeps(Boolean(options.noDeps));`
`325`	`325`	`req.setNoOverwrite(Boolean(options.noOverwrite));`
`326`	`326`	`if (options.installLocation === LibraryLocation.BUILTIN) {`
`327`	`327`	`req.setInstallLocation(`

Comments

(0)