#1084, #1156 Various library/platform index update fixes #1418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

kittaakos merged 1 commit into arduino:main from kittaakos:#1156

Oct 5, 2022

Merged

#1084, #1156 Various library/platform index update fixes #1418

kittaakos merged 1 commit into arduino:main from kittaakos:#1156

Oct 5, 2022

Conversation

kittaakos

Copy link

Contributor

@kittaakos kittaakos commented Sep 9, 2022 •

edited

Loading

Motivation

IDE2 should start when an invalid 3rd party URL is set and #directories/data is empty. (IDE is non-functional if package index can't be loaded #1084 )
IDE2 should not run the library index update when on 3rd party URL changes from Settings. (Only package indexes should updated after changing the "Additional Boards Manager URL" preference. #1156 )
IDE2 does not automatically update the platform/library indexes after the app starts but only runs the index update if the last update was later than 4 hours. If arduino.checkForUpdates is false no automatic index update will run.
Users can manually trigger a package/library/both index updates with a command.

Change description

Other information

Closes #1084
Closes #1156

Reviewer checklist

PR addresses a single concern.
The PR has no duplicates (please search among the Pull Requests before creating one)
PR title and description are properly filled.
Docs have been added / updated (for bug fixes / features)

@kittaakos kittaakos added topic: code type: imperfection topic: CLI labels

Sep 9, 2022

@kittaakos kittaakos changed the title ~~(削除) #1084, #1156 Various library and platform index fixes (削除ここまで)~~ (追記) #1084, #1156 Various library/platform index update fixes (追記ここまで)

Sep 9, 2022

@kittaakos kittaakos added the status: on hold label

Sep 21, 2022

@kittaakos kittaakos force-pushed the #1156 branch 3 times, most recently from e248e07 to 8c466d2 Compare

September 29, 2022 14:19

@kittaakos kittaakos marked this pull request as ready for review

September 29, 2022 14:26

@kittaakos kittaakos requested review from per1234 and AlbyIanna

September 29, 2022 14:26

per1234

per1234 requested changes

Sep 30, 2022

View reviewed changes

arduino-ide-extension/src/browser/contributions/update-indexes.ts Outdated Show resolved Hide resolved

@per1234 per1234 mentioned this pull request

Oct 2, 2022

[breaking] Refactor DownloadProgress gRPC message: more clear field meaning. arduino/arduino-cli#1875

Merged

5 tasks


 Various library/platform index update fixes

0a02d77

 - IDE2 can start if the package index download fails. Closes arduino#1084
 - Split the lib and platform index update. Closes arduino#1156
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>