Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

[breaking] Refactor DownloadProgress gRPC message: more clear field meaning. #1875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmaglie merged 5 commits into arduino:master from cmaglie:download_progress_refactor
Oct 5, 2022

Conversation

Copy link
Member

@cmaglie cmaglie commented Sep 13, 2022

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?
    Refactor the DownloadProgress messages.
  • What is the current behavior?
    It's not very clear how the fields in the progress reports are populated.
  • What is the new behavior?
    The new message structure should be much more clearer.

@cmaglie cmaglie self-assigned this Sep 13, 2022
@cmaglie cmaglie force-pushed the download_progress_refactor branch from 3f11693 to 9a43ead Compare September 13, 2022 14:07
@cmaglie cmaglie added type: enhancement Proposed improvement priority: medium Resolution is a medium priority topic: gRPC Related to the gRPC interface criticality: low Of low impact labels Sep 13, 2022
Copy link

codecov bot commented Sep 13, 2022 •
edited
Loading

Codecov Report

Base: 36.58% // Head: 36.77% // Increases project coverage by +0.19% 🎉

Coverage data is based on head (c28cfd3) compared to base (5730e2e).
Patch coverage: 58.06% of modified lines in pull request are covered.

Additional details and impacted files 
@@ Coverage Diff @@
## master #1875 +/- ##
==========================================
+ Coverage 36.58% 36.77% +0.19% 
==========================================
 Files 231 231 
 Lines 19696 19685 -11 
==========================================
+ Hits 7206 7240 +34 
+ Misses 11659 11614 -45 
 Partials 831 831
Flag Coverage Δ
unit 36.77% <58.06%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cli/core/search.go 0.00% <0.00%> (ø)
cli/core/update_index.go 0.00% <0.00%> (ø)
cli/update/update.go 0.00% <0.00%> (ø)
commands/daemon/daemon.go 0.00% <0.00%> (ø)
commands/instances.go 39.79% <15.38%> (+0.70%) ⬆️
arduino/httpclient/httpclient.go 60.71% <54.54%> (-6.56%) ⬇️
cli/output/rpc_progress.go 80.88% <88.88%> (+12.13%) ⬆️
arduino/cores/packagemanager/download.go 29.48% <100.00%> (+6.59%) ⬆️
arduino/resources/download.go 62.50% <100.00%> (-5.36%) ⬇️
cli/instance/instance.go 57.28% <100.00%> (-0.42%) ⬇️
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cmaglie cmaglie marked this pull request as draft September 19, 2022 10:33
@cmaglie cmaglie force-pushed the download_progress_refactor branch from 6b5d96c to 8a440f5 Compare September 22, 2022 13:11
@cmaglie cmaglie force-pushed the download_progress_refactor branch 2 times, most recently from 805f6bc to 12ce8fc Compare September 22, 2022 15:47
@cmaglie cmaglie force-pushed the download_progress_refactor branch from 12ce8fc to 13b3f85 Compare September 22, 2022 16:08
@cmaglie cmaglie marked this pull request as ready for review September 23, 2022 08:11 
Co-authored-by: per1234 <accounts@perglass.com>
Copy link
Contributor

@cmaglie, could you please merge this PR if it's ready? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

+1 more reviewer

@umbynos umbynos umbynos approved these changes

Reviewers whose approvals may not affect merge requirements
Labels
criticality: low Of low impact priority: medium Resolution is a medium priority topic: gRPC Related to the gRPC interface type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /