-
-
Notifications
You must be signed in to change notification settings - Fork 489
fix board selection and workspace input dialogs width and height #1406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Having this giant hard-coded length for the new sketch file dialog only while having the default everywhere else is an unacceptable change. #1350 (comment)
New:
Screen Shot 2022年09月15日 at 11 06 40
Rename:
Screen Shot 2022年09月15日 at 11 06 51
Delete:
Screen Shot 2022年09月15日 at 11 08 47
The boards list still disappears when I filter: #1350 (comment)
no_list.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does not fix #1350. See why: #1406 (comment).
9ab3060 to
ff91c27
Compare
c54e150 to
ff91c27
Compare
Checked the build, the delete dialog is missing the fixed width:
Schermata 2022年09月19日 alle 15 29 37
Once it is fixed the PR is ok for me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The New, Rename, and Delete tabs have different sizes:
Screen Shot 2022年09月19日 at 18 05 28
Screen Shot 2022年09月19日 at 18 05 48
Screen Shot 2022年09月19日 at 18 06 12
The board list height changes when filtering in the list (#1350 (comment)):
lis_resize.mp4
Should this PR cover #1350 (comment)? If yes, let's make this #1382 dependent. You can also cherry-pick the overflow changes or copy them here.
60819f1 to
2603e05
Compare
Thanks for the review @kittaakos and @91volt. I've fixed the remaining dialogs, now the min-size for any dialog is set by default to 480px.
I've fixed the board list changing size when filtering, and took the liberty to change the UI when no board is found for the search made by to user:
image
The alternative was to show a white empty rectangle, which wasn't very nice to me. @91volt do you like it? ☝️
Should this PR cover #1350 (comment)? If yes, let's make this #1382 dependent. You can also cherry-pick the overflow changes or copy them here.
@kittaakos since #1382 is already approved, I'm okay with waiting for it to be merged.
2603e05 to
0a0314d
Compare
@kittaakos since #1382 is already approved, I'm okay with waiting for it to be merged.
Could you please rebase? #1382 has been merged. Your branch is three commits behind the main. Thank you!
0a0314d to
9b3cc9a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great. Thank you!
Motivation
Some dialogs have unexpected behaviours as described in #1350
Change description
fixed width and height of workspace input dialog and board selection dialog
Other information
Closes #1350
Reviewer checklist