Commit 2603e05

author

Alberto Iannaccone

committed

board select dialog: show variant text when no board is found

1 parent 141d118 commit 2603e05Copy full SHA for 2603e05

File tree

2 files changed

+32

-14

lines changed

arduino-ide-extension/src/browser
- boards
  - boards-config.tsx
- style
  - boards-config-dialog.css

2 files changed

+32

-14

lines changed

`‎arduino-ide-extension/src/browser/boards/boards-config.tsx‎`

Lines changed: 24 additions & 14 deletions

Original file line number	Diff line number	Diff line change
`@@ -299,6 +299,18 @@ export class BoardsConfig extends React.Component<`
`299`	`299`	`}`
`300`	`300`	`}`
`301`	`301`
	`302`	`+ const boardsList = Array.from(distinctBoards.values()).map((board) => (`
	`303`	`+ <Item<BoardWithPackage>`
	`304`	`+ key={toKey(board)}`
	`305`	`+ item={board}`
	`306`	`+ label={board.name}`
	`307`	`+ details={board.details}`
	`308`	`+ selected={board.selected}`
	`309`	`+ onClick={this.selectBoard}`
	`310`	`+ missing={board.missing}`
	`311`	`+ />`
	`312`	`+ ));`
	`313`	`+`
`302`	`314`	`return (`
`303`	`315`	`<React.Fragment>`
`304`	`316`	`<div className="search">`
`@@ -315,19 +327,17 @@ export class BoardsConfig extends React.Component<`
`315`	`327`	`/>`
`316`	`328`	`<i className="fa fa-search"></i>`
`317`	`329`	`</div>`
`318`		`- <div className="boards list">`
`319`		`- {Array.from(distinctBoards.values()).map((board) => (`
`320`		`- <Item<BoardWithPackage>`
`321`		`- key={toKey(board)}`
`322`		`- item={board}`
`323`		`- label={board.name}`
`324`		`- details={board.details}`
`325`		`- selected={board.selected}`
`326`		`- onClick={this.selectBoard}`
`327`		`- missing={board.missing}`
`328`		`- />`
`329`		`- ))}`
`330`		`- </div>`
	`330`	`+ {boardsList.length > 0 ? (`
	`331`	`+ <div className="boards list">{boardsList}</div>`
	`332`	`+ ) : (`
	`333`	`+ <div className="no-result">`
	`334`	`+ {nls.localize(`
	`335`	`+ 'arduino/board/noBoardsFound',`
	`336`	`+ 'No boards found for "{0}"',`
	`337`	`+ query`
	`338`	`+ )}`
	`339`	`+ </div>`
	`340`	`+ )}`
`331`	`341`	`</React.Fragment>`
`332`	`342`	`);`
`333`	`343`	`}`
`@@ -342,7 +352,7 @@ export class BoardsConfig extends React.Component<`
`342`	`352`	`);`
`343`	`353`	`}`
`344`	`354`	`return !ports.length ? (`
`345`		`- <div className="loading noselect">`
	`355`	`+ <div className="no-result">`
`346`	`356`	`{nls.localize('arduino/board/noPortsDiscovered', 'No ports discovered')}`
`347`	`357`	`</div>`
`348`	`358`	`) : (`

`‎arduino-ide-extension/src/browser/style/boards-config-dialog.css‎`

Lines changed: 8 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -295,3 +295,11 @@ div#select-board-dialog .selectBoardContainer .list .item.selected i {`
`295`	`295`	`display: none;`
`296`	`296`	`}`
`297`	`297`	`}`
	`298`	`+`
	`299`	`+#select-board-dialog .no-result {`
	`300`	`+ text-transform: uppercase;`
	`301`	`+ height: 100%;`
	`302`	`+ user-select: none;`
	`303`	`+ padding: 10px 5px;`
	`304`	`+ overflow-wrap: break-word;`
	`305`	`+}`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit 2603e05

File tree

2 files changed

2 files changed

`‎arduino-ide-extension/src/browser/boards/boards-config.tsx‎`

`‎arduino-ide-extension/src/browser/style/boards-config-dialog.css‎`

0 commit comments