-
-
Notifications
You must be signed in to change notification settings - Fork 489
Move primary buttons on the right of the dialogs #1382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
arduino-ide-extension/src/browser/library/library-list-widget.ts
Outdated
Show resolved
Hide resolved
arduino-ide-extension/src/browser/theia/workspace/workspace-input-dialog.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm the buttons are in the correct position. I have checked:
- new sketch file,
- 3rd party URLs, and
- install lib with dependencies.
I found a problem:
invalid_filename.mp4
arduino-ide-extension/src/browser/library/library-list-widget.ts
Outdated
Show resolved
Hide resolved
Thanks for the feedback @kittaakos, I moved the close button before the last child (primary button), now it appears like this:
This was the older behavior:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified. Thank you!
Uh oh!
There was an error while loading. Please reload this page.
Motivation
In some dialogs, the primary button is not on the right.
Change description
Move all primary buttons in dialogs to the right.
Screenshot 2022年09月01日 142402
Screenshot 2022年09月01日 142929
Screenshot 2022年09月02日 114253
Other information
Closes #1368.
Reviewer checklist