-
-
Notifications
You must be signed in to change notification settings - Fork 491
Fix settings dialog size #1172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix settings dialog size #1172
Conversation
...e to fix the max-width
The dialog width is correct now, thank you for the fix, but the height of the Network tab is incorrect. (See here) Is there a chance to fix both issues together?
The dialog width is correct now, thank you for the fix, but the height of the Network tab is incorrect. (See here) Is there a chance to fix both issues together?
Thank you, I didn't notice it.
Fixed👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works as expected. Thank you!
Uh oh!
There was an error while loading. Please reload this page.
Motivation
The
max-widthrule of the settings dialog is being overridden by the default dialogmax-width, resulting in a VERY big (and ugly) dialog. Also, the height of the dialog shouldn't change when switching to the Network tab.Change description
Other information
The credit for this fix goes to @davegarthsimpson, who suggested it 🌼
Fixes #1158
Reviewer checklist