Commit fb690c9

author

Alberto Iannaccone

authored

Fix settings dialog size (#1172)

* give an id to the settings dialog to grant higher priority to css rule to fix the max-width * fix settings dialog height

1 parent a003831 commit fb690c9Copy full SHA for fb690c9

File tree

-3

lines changed

arduino-ide-extension/src/browser
- dialogs/settings
  - settings-dialog.tsx
- style
  - settings-dialog.css

-3

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ export class SettingsDialog extends AbstractDialog<Promise<Settings>> {`
`63`	`63`	`protected override readonly props: SettingsDialogProps`
`64`	`64`	`) {`
`65`	`65`	`super(props);`
`66`		`- this.node.classList.add('arduino-settings-dialog-container');`
	`66`	`+ this.node.id='arduino-settings-dialog-container';`
`67`	`67`	`this.contentNode.classList.add('arduino-settings-dialog');`
`68`	`68`	`this.appendCloseButton(`
`69`	`69`	`nls.localize('vscode/issueMainService/cancel', 'Cancel')`

Lines changed: 7 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,11 @@`
`1`		`-.arduino-settings-dialog-container > .dialogBlock {`
`2`		`- width:calc(100%-96px);`
	`1`	`+#arduino-settings-dialog-container > .dialogBlock {`
	`2`	`+ height:531px;;`
`3`	`3`	`max-width: 740px !important;`
	`4`	`+ width: calc(100% - 96px);`
	`5`	`+}`
	`6`	`+`
	`7`	`+#arduino-settings-dialog-container > .dialogBlock > .dialogContent {`
	`8`	`+ justify-content: flex-start;`
`4`	`9`	`}`
`5`	`10`
`6`	`11`	`.arduino-settings-dialog .content {`

Comments

(0)