-
-
Notifications
You must be signed in to change notification settings - Fork 422
Fix user network config being ignored in package manger operations #2889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix user network config being ignored in package manger operations #2889
Conversation
During the `Build()` we forgot to pass the pmb downloaderConfig property
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified this fixes #2888. Thanks Alessio!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## master #2889 +/- ## ======================================= Coverage 67.83% 67.83% ======================================= Files 238 238 Lines 22418 22419 +1 ======================================= + Hits 15208 15209 +1 Misses 6010 6010 Partials 1200 1200
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
We correctly pass the downloader config during the
Build()of the package managerWhat is the current behavior?
Currently, the downloader config is not passed when building the final package manager. This led to ignoring user network configs.
What is the new behavior?
We correctly pass the downloader configs.
Does this PR introduce a breaking change, and is titled accordingly?
Other information