-
-
Notifications
You must be signed in to change notification settings - Fork 423
Increase priority of manually-installed platform. #2810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@cmaglie
cmaglie
force-pushed
the
installed_platform_priority
branch
from
January 13, 2025 15:38
237d69b
to
c8b0fc7
Compare
@cmaglie
cmaglie
added
type: enhancement
Proposed improvement
topic: code
Related to content of the project itself
labels
Jan 13, 2025
@cmaglie
cmaglie
force-pushed
the
installed_platform_priority
branch
2 times, most recently
from
January 16, 2025 14:04
c3dedb2
to
4de49d3
Compare
@cmaglie
cmaglie
force-pushed
the
installed_platform_priority
branch
3 times, most recently
from
February 4, 2025 08:23
d248b1e
to
eb5fe21
Compare
It has been replaced by a much simpler check on the version field.
@cmaglie
cmaglie
force-pushed
the
installed_platform_priority
branch
from
February 4, 2025 08:59
eb5fe21
to
69136e9
Compare
@cmaglie
cmaglie
force-pushed
the
installed_platform_priority
branch
from
February 4, 2025 09:58
69136e9
to
dad5063
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@ ## master #2810 +/- ## ========================================== + Coverage 67.74% 67.80% +0.06% ========================================== Files 238 238 Lines 22410 22416 +6 ========================================== + Hits 15181 15200 +19 + Misses 6034 6024 -10 + Partials 1195 1192 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)configuration.schema.json
updated if new parameters are added.What kind of change does this PR introduce?
Makes the manually-installed platform always preferred over the platforms installed through Board Manager
What is the current behavior?
TODO
What is the new behavior?
TODO
Does this PR introduce a breaking change, and is titled accordingly?
Other information
Draft PR to run the test-suite