Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit 4de49d3

Browse files
committed
Fixed unit tests
1 parent 133c821 commit 4de49d3

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

‎commands/service_upload_test.go‎

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -132,10 +132,12 @@ func TestDetermineBuildPathAndSketchName(t *testing.T) {
132132
}
133133

134134
func TestUploadPropertiesComposition(t *testing.T) {
135-
pmb := packagemanager.NewBuilder(nil, nil, nil, nil, nil, "test", downloader.GetDefaultConfig())
136-
errs := pmb.LoadHardwareFromDirectory(paths.New("testdata", "upload", "hardware"))
135+
userdir := paths.New("testdata", "upload")
136+
hwdir := userdir.Join("hardware")
137+
pmb := packagemanager.NewBuilder(nil, nil, hwdir, nil, nil, "test", downloader.GetDefaultConfig())
138+
errs := pmb.LoadHardwareFromDirectory(hwdir)
137139
require.Len(t, errs, 0)
138-
buildPath1 := paths.New("testdata", "upload", "build_path_1")
140+
buildPath1 := userdir.Join("build_path_1")
139141
logrus.SetLevel(logrus.TraceLevel)
140142
type test struct {
141143
importDir *paths.Path

‎internal/arduino/cores/packagemanager/package_manager_test.go‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ var dataDir1 = paths.New("testdata", "data_dir_1")
3939
var extraHardware = paths.New("testdata", "extra_hardware")
4040

4141
func TestFindBoardWithFQBN(t *testing.T) {
42-
pmb := NewBuilder(customHardware, customHardware, nil, customHardware, customHardware, "test", downloader.GetDefaultConfig())
42+
pmb := NewBuilder(customHardware, customHardware, customHardware, customHardware, customHardware, "test", downloader.GetDefaultConfig())
4343
pmb.LoadHardwareFromDirectory(customHardware)
4444
pm := pmb.Build()
4545
pme, release := pm.NewExplorer()
@@ -57,7 +57,7 @@ func TestFindBoardWithFQBN(t *testing.T) {
5757

5858
func TestResolveFQBN(t *testing.T) {
5959
// Pass nil, since these paths are only used for installing
60-
pmb := NewBuilder(nil, nil, nil, nil, nil, "test", downloader.GetDefaultConfig())
60+
pmb := NewBuilder(nil, nil, customHardware, nil, nil, "test", downloader.GetDefaultConfig())
6161
// Hardware from main packages directory
6262
pmb.LoadHardwareFromDirectory(dataDir1.Join("packages"))
6363
// This contains the arduino:avr core

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /