-
-
Notifications
You must be signed in to change notification settings - Fork 423
Fixed locales (translations) not being detected with default config #2724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@cmaglie
cmaglie
requested review from
umbynos,
alessio-perugini and
MatteoPologruto
October 7, 2024 16:36
@cmaglie
cmaglie
added
type: imperfection
Perceived defect in any part of project
topic: CLI
Related to the command line interface
labels
Oct 7, 2024
@cmaglie
cmaglie
force-pushed
the
fix_i18n
branch
from
October 7, 2024 16:39
9c3ddd1
to
5ba6901
Compare
umbynos
umbynos
approved these changes
Oct 8, 2024
@cmaglie
cmaglie
force-pushed
the
fix_i18n
branch
from
November 6, 2024 12:56
61d1f5b
to
3f5568f
Compare
@cmaglie
cmaglie
force-pushed
the
fix_i18n
branch
from
November 6, 2024 15:04
3f5568f
to
01e72e3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@ ## master #2724 +/- ## ========================================== - Coverage 67.62% 67.55% -0.07% ========================================== Files 237 237 Lines 22354 22356 +2 ========================================== - Hits 15116 15103 -13 - Misses 6048 6063 +15 Partials 1190 1190
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)configuration.schema.json
updated if new parameters are added.What kind of change does this PR introduce?
Fixed incorrect locales detection.
What is the current behavior?
The
en
version is displayed instead ofit
What is the new behavior?
Does this PR introduce a breaking change, and is titled accordingly?
Other information