Commit 5ba6901

committed

Fixed locales (translations) not being detected with default config

1 parent ac6ec6d commit 5ba6901Copy full SHA for 5ba6901

File tree

+14

-2

lines changed

commands
- service_settings_test.go
internal
- cli/configuration
  - defaults.go
- integrationtest/config
  - config_test.go

+14

-2

lines changed

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,6 @@ func TestGetAll(t *testing.T) {`
`62`	`62`	"user": `+defaultUserDir.GetEncodedValue()+`
`63`	`63`	`},`
`64`	`64`	`"library": {},`
`65`		`- "locale": "en",`
`66`	`65`	`"logging": {`
`67`	`66`	`"format": "text",`
`68`	`67`	`"level": "info"`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,7 @@ func SetDefaults(settings *Settings) {`
`73`	`73`	`setKeyTypeSchema("network.user_agent_ext", "")`
`74`	`74`
`75`	`75`	`// locale`
`76`		`- setDefaultValueAndKeyTypeSchema("locale", "en")`
	`76`	`+ setKeyTypeSchema("locale", "")`
`77`	`77`	`}`
`78`	`78`
`79`	`79`	`// InjectEnvVars change settings based on the environment variables values`

Lines changed: 13 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -931,3 +931,16 @@ func TestConfigViaEnvVars(t *testing.T) {`
`931`	`931`	`require.NoError(t, err)`
`932`	`932`	`require.Equal(t, "20\n\n", string(out))`
`933`	`933`	`}`
	`934`	`+`
	`935`	`+func TestI18N(t *testing.T) {`
	`936`	`+ env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)`
	`937`	`+ defer env.CleanUp()`
	`938`	`+`
	`939`	`+ out, _, err := cli.RunWithCustomEnv(map[string]string{"LANG": "it"})`
	`940`	`+ require.NoError(t, err)`
	`941`	`+ require.Contains(t, string(out), "Comandi disponibili")`
	`942`	`+`
	`943`	`+ out, _, err = cli.RunWithCustomEnv(map[string]string{"LANG": "en"})`
	`944`	`+ require.NoError(t, err)`
	`945`	`+ require.Contains(t, string(out), "Available Commands")`
	`946`	`+}`

Comments

(0)