Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

core: list return empty array instead of null, when no cores are installed #2691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alessio-perugini merged 1 commit into master from fix-core-list-null
Aug 13, 2024

Conversation

Copy link
Contributor

@alessio-perugini alessio-perugini commented Aug 13, 2024 •
edited
Loading

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Changes the value of the json output when no core are installed

What is the current behavior?

Currently if no cores are installed we return a null value

What is the new behavior?

When no cores are installed we return an empty array []

Does this PR introduce a breaking change, and is titled accordingly?

Other information

@alessio-perugini alessio-perugini added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Aug 13, 2024
Copy link

codecov bot commented Aug 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.67%. Comparing base (a0d912d) to head (82de269).

Additional details and impacted files 
@@ Coverage Diff @@
## master #2691 +/- ##
==========================================
- Coverage 67.77% 67.67% -0.11% 
==========================================
 Files 234 234 
 Lines 22176 22176 
==========================================
- Hits 15030 15007 -23 
- Misses 5963 5990 +27 
+ Partials 1183 1179 -4
Flag Coverage Δ
unit 67.67% <100.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verify this fixes #2690

Thanks Alessio!

alessio-perugini reacted with hooray emoji
@alessio-perugini alessio-perugini deleted the fix-core-list-null branch August 13, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

@cmaglie cmaglie Awaiting requested review from cmaglie

Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

core list machine readable output is null when no platforms are installed

AltStyle によって変換されたページ (->オリジナル) /