Commit c5812ee

authored

core: list return empty array instead of null, when no cores are installed (#2691)

1 parent a0d912d commit c5812eeCopy full SHA for c5812ee

File tree

-3

lines changed

-3

lines changed

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -88,9 +88,9 @@ func GetList(ctx context.Context, srv rpc.ArduinoCoreServiceServer, inst *rpc.In`
`88`	`88`	`}`
`89`	`89`
`90`	`90`	`func newCoreListResult(in []rpc.PlatformSummary, updatableOnly bool) coreListResult {`
`91`		`- res := &coreListResult{updatableOnly: updatableOnly}`
`92`		`- for _, platformSummary := range in {`
`93`		`- res.Platforms = append(res.Platforms, result.NewPlatformSummary(platformSummary))`
	`91`	`+ res := &coreListResult{updatableOnly: updatableOnly, Platforms: make([]*result.PlatformSummary, len(in))}`
	`92`	`+ for i, platformSummary := range in {`
	`93`	`+ res.Platforms[i] = result.NewPlatformSummary(platformSummary)`
`94`	`94`	`}`
`95`	`95`	`return res`
`96`	`96`	`}`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1174,6 +1174,7 @@ func TestCoreListWhenNoPlatformAreInstalled(t *testing.T) {`
`1174`	`1174`	`stdout, _, err := cli.Run("core", "list", "--json")`
`1175`	`1175`	`require.NoError(t, err)`
`1176`	`1176`	requirejson.Query(t, stdout, `.platforms \| length`, `0`)
	`1177`	+ requirejson.Query(t, stdout, `.platforms \| select(.!=null)`, `[]`)
`1177`	`1178`
`1178`	`1179`	`stdout, _, err = cli.Run("core", "list")`
`1179`	`1180`	`require.NoError(t, err)`

Comments

(0)