Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Fixed missing ARDUINO_USER_AGENT env var setting. #2501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmaglie merged 2 commits into arduino:master from cmaglie:fix_missing_env_user_agent
Jan 16, 2024

Conversation

Copy link
Member

@cmaglie cmaglie commented Jan 15, 2024

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Fix ARDUINO_USER_AGENT env var.

What is the current behavior?

The ARDUINO_USER_AGENT is not set during the build.

What is the new behavior?

The ARDUINO_USER_AGENT is set during the build.

Does this PR introduce a breaking change, and is titled accordingly?

No

Other information

Should fix #2499

@cmaglie cmaglie self-assigned this Jan 15, 2024
@cmaglie cmaglie added type: imperfection Perceived defect in any part of project topic: build-process Related to the sketch build process labels Jan 15, 2024
Copy link
Member Author

cmaglie commented Jan 15, 2024

We must backport this one in the 0.35.x branch so it gets released with the next Arduino IDE @kittaakos @umbynos

kittaakos, alessio-perugini, and umbynos reacted with thumbs up emoji PaulStoffregen reacted with heart emoji

@cmaglie cmaglie changed the title (削除) Fixed missing ARDUINO_USER_AGENT env var setting. (削除ここまで) (追記) Fixed missing ARDUINO_USER_AGENT env var setting. (追記ここまで) Jan 15, 2024
Copy link

codecov bot commented Jan 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (31e0341) 68.88% compared to head (94b5c50) 68.81%.
Report is 3 commits behind head on master.

Additional details and impacted files 
@@ Coverage Diff @@
## master #2501 +/- ##
==========================================
- Coverage 68.88% 68.81% -0.08% 
==========================================
 Files 204 204 
 Lines 20455 20457 +2 
==========================================
- Hits 14091 14078 -13 
- Misses 5206 5222 +16 
+ Partials 1158 1157 -1
Flag Coverage Δ
unit 68.81% <100.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@alessio-perugini alessio-perugini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch, indeed in the legacy we were passing the user agent env.

@per1234 per1234 added the topic: code Related to content of the project itself label Jan 16, 2024
@cmaglie cmaglie merged commit 8115da1 into arduino:master Jan 16, 2024
@cmaglie cmaglie deleted the fix_missing_env_user_agent branch January 16, 2024 13:18
cmaglie added a commit that referenced this pull request Jan 16, 2024 
* Added integration test
* Fixed missing ARDUINO_USER_AGENT env var
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatteoPologruto MatteoPologruto Awaiting requested review from MatteoPologruto

2 more reviewers

@alessio-perugini alessio-perugini alessio-perugini approved these changes

@umbynos umbynos umbynos approved these changes

Reviewers whose approvals may not affect merge requirements
Labels
topic: build-process Related to the sketch build process topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ARDUINO_USER_AGENT environment variable not set

AltStyle によって変換されたページ (->オリジナル) /