Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

chore: pinned Arduino CLI 0.35.1 #2332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kittaakos merged 2 commits into main from use-cli-35.0
Jan 17, 2024
Merged

chore: pinned Arduino CLI 0.35.1 #2332

kittaakos merged 2 commits into main from use-cli-35.0
Jan 17, 2024

Conversation

Copy link
Contributor

@kittaakos kittaakos commented Jan 15, 2024 •
edited
Loading

Motivation

  • IDE2 should use the 0.35.1 of the Arduino CLI.
  • Use the latest (>=1.85) preferred value of the source.fixAll.eslint VS Code settings.

Change description

  • Pinned the CLI version,
  • Update the shared settings.json file

Other information

Closes #2318

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)
 

From VS Code `>=1.85`
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos kittaakos added type: enhancement Proposed improvement topic: CLI Related to Arduino CLI labels Jan 15, 2024
@kittaakos kittaakos marked this pull request as draft January 16, 2024 06:59
Copy link
Contributor Author

Depends on arduino/arduino-cli#2501. There will be a new CLI release that should be integrated into IDE2
PaulStoffregen reacted with thumbs up emoji

@kittaakos kittaakos changed the title (削除) chore: pinned Arduino CLI 0.35.0 (削除ここまで) (追記) chore: pinned Arduino CLI 0.35.1 (追記ここまで) Jan 16, 2024 
Closes #2318
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos kittaakos marked this pull request as ready for review January 16, 2024 21:40
Copy link
Contributor Author

IDE2 uses the latest CLI now. Please review. Thank you!

@kittaakos kittaakos added type: imperfection Perceived defect in any part of project and removed type: enhancement Proposed improvement labels Jan 16, 2024
Copy link

IDE2 uses the latest CLI now. Please review. Thank you!

Tested arduino-ide_nightly-20240117_Linux_64bit just now. Still has issue #2318.

image

Is there a newer build I should test?

Copy link
Contributor Author

Is there a newer build I should test?

The fix still needs to be in the nightly. The PR (#2332) must be reviewed, approved, and merged. Then, it will get into the following nightly build.

However, you can try out the tester build from the PR. Please see the docs on downloading and using the tester build: https://github.com/arduino/arduino-ide/blob/main/docs/contributor-guide/beta-testing.md.

Please let me know if you need assistance or if the fix does not work. I appreciate your help.

Copy link

Tested the artifact build. Can confirm it fixes #2318.

image

kittaakos reacted with heart emoji

Copy link
Contributor Author

I also verified it. It works.

Build from the PR ✅

Screenshot 2024年01月17日 at 13 41 26

Nightly build (nightly-20240117) ❌

Screenshot 2024年01月17日 at 13 40 45

@kittaakos kittaakos merged commit b8dd39c into main Jan 17, 2024
@kittaakos kittaakos deleted the use-cli-35.0 branch January 17, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmaglie cmaglie cmaglie approved these changes

@davegarthsimpson davegarthsimpson Awaiting requested review from davegarthsimpson

Assignees
No one assigned
Labels
topic: CLI Related to Arduino CLI type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ARDUINO_USER_AGENT environment variable not set

AltStyle によって変換されたページ (->オリジナル) /