Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

[breaking] fix: remove tree config lookup #2085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Bikappa merged 6 commits into master from fix/remove-tree-config-lookup
Feb 27, 2023

Conversation

Copy link
Contributor

@Bikappa Bikappa commented Feb 23, 2023 •
edited
Loading

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Dismiss the automatic config file lookup in the current working directory and its parents.

What is the current behavior?

When the user does not specify a configuration file, the presence of one is checked in the current working directory and iteratively from the closest parent directory to the root.

What is the new behavior?

The described config file lookup is dropped. It becomes possible to specify a configuration file only by the command line flag --config-file or by changing the arduino data directory.

Does this PR introduce a breaking change, and is titled accordingly?

Yes, applications relying on the previous silent current working directory and parents lookup will be disregarded.

Other information

Fixes #758

Copy link

codecov bot commented Feb 23, 2023 •
edited
Loading

Codecov Report

Base: 36.56% // Head: 36.52% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (bf6da0a) compared to base (c95f890).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@ Coverage Diff @@
## master #2085 +/- ##
==========================================
- Coverage 36.56% 36.52% -0.04% 
==========================================
 Files 229 229 
 Lines 19538 19526 -12 
==========================================
- Hits 7144 7132 -12 
- Misses 11555 11556 +1 
+ Partials 839 838 -1
Flag Coverage Δ
unit 36.52% <50.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
main.go 0.00% <0.00%> (ø)
configuration/configuration.go 46.34% <100.00%> (-3.66%) ⬇️
arduino/cores/packagemanager/package_manager.go 67.46% <0.00%> (-0.73%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

Shouldn't this be marked as breaking compatibility? And set to close #758?

@Bikappa Bikappa changed the title (削除) Fix/remove tree config lookup (削除ここまで) (追記) fix: remove tree config lookup (追記ここまで) Feb 23, 2023
@Bikappa Bikappa force-pushed the fix/remove-tree-config-lookup branch from 468794c to 384cd3d Compare February 23, 2023 15:27
Copy link
Contributor Author

Bikappa commented Feb 23, 2023

Shouldn't this be marked as breaking compatibility? And set to close #758?

@matthijskooijman yes, that's correct. It will be marked as such once it leaves the draft mode, at the latest.

@Bikappa Bikappa force-pushed the fix/remove-tree-config-lookup branch 2 times, most recently from b7ef8b7 to 7bf2ec8 Compare February 23, 2023 16:23
@Bikappa Bikappa force-pushed the fix/remove-tree-config-lookup branch from 7bf2ec8 to d9d32a7 Compare February 23, 2023 17:07
@Bikappa Bikappa self-assigned this Feb 24, 2023
@Bikappa Bikappa changed the title (削除) fix: remove tree config lookup (削除ここまで) (追記) [breaking] fix: remove tree config lookup (追記ここまで) Feb 24, 2023
@Bikappa Bikappa force-pushed the fix/remove-tree-config-lookup branch from a123e56 to bf6da0a Compare February 24, 2023 09:20
@Bikappa Bikappa marked this pull request as ready for review February 24, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmaglie cmaglie cmaglie approved these changes

@per1234 per1234 Awaiting requested review from per1234

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Loading arduino-cli.yaml from current directory might be unexpected or unsafe

AltStyle によって変換されたページ (->オリジナル) /