Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Refactored build-properties creation (and removed some legacy code) #2082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmaglie merged 12 commits into arduino:master from cmaglie:build_properties_refactor
Mar 2, 2023

Conversation

Copy link
Member

@cmaglie cmaglie commented Feb 21, 2023 •
edited
Loading

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)

What kind of change does this PR introduce?

It moves most of the build-properties creation out of the legacy package. This has some advantages:

What is the current behavior?

Build properties are missing for upload recipes.

What is the new behavior?

Build properties are now available in upload recipes.

Does this PR introduce a breaking change, and is titled accordingly?

No breaking changes.

Other information

@cmaglie cmaglie self-assigned this Feb 21, 2023
@cmaglie cmaglie added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Feb 21, 2023
@cmaglie cmaglie added this to the Arduino CLI 1.0 milestone Feb 21, 2023
@cmaglie cmaglie force-pushed the build_properties_refactor branch 2 times, most recently from 2d70528 to 87f06d7 Compare February 22, 2023 14:23
Copy link

codecov bot commented Feb 22, 2023 •
edited
Loading

Codecov Report

Base: 36.54% // Head: 36.65% // Increases project coverage by +0.10% 🎉

Coverage data is based on head (6ad5342) compared to base (c660b33).
Patch coverage: 82.56% of modified lines in pull request are covered.

Additional details and impacted files 
@@ Coverage Diff @@
## master #2082 +/- ##
==========================================
+ Coverage 36.54% 36.65% +0.10% 
==========================================
 Files 229 229 
 Lines 19538 19538 
==========================================
+ Hits 7141 7162 +21 
+ Misses 11557 11541 -16 
+ Partials 840 835 -5
Flag Coverage Δ
unit 36.65% <82.56%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commands/compile/compile.go 0.00% <ø> (ø)
commands/upload/upload.go 55.81% <ø> (+1.08%) ⬆️
legacy/builder/builder.go 84.84% <ø> (ø)
legacy/builder/setup_build_properties.go 68.75% <0.00%> (-17.12%) ⬇️
legacy/builder/types/context.go 73.13% <ø> (-0.40%) ⬇️
legacy/builder/target_board_resolver.go 70.96% <40.00%> (-2.57%) ⬇️
arduino/cores/packagemanager/package_manager.go 71.07% <84.84%> (+2.88%) ⬆️
arduino/cores/board.go 92.06% <100.00%> (+0.12%) ⬆️
arduino/cores/cores.go 62.37% <100.00%> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cmaglie cmaglie marked this pull request as ready for review February 22, 2023 14:40
cmaglie added 12 commits February 27, 2023 19:23 
Equivalent change, should not change behaviour
@cmaglie cmaglie force-pushed the build_properties_refactor branch from 05a1f86 to 6ad5342 Compare February 27, 2023 18:23
Copy link
Contributor

@Bikappa Bikappa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cmaglie cmaglie merged commit 2f5b767 into arduino:master Mar 2, 2023
@cmaglie cmaglie deleted the build_properties_refactor branch March 2, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 Awaiting requested review from per1234

@umbynos umbynos Awaiting requested review from umbynos

@MatteoPologruto MatteoPologruto Awaiting requested review from MatteoPologruto

1 more reviewer

@Bikappa Bikappa Bikappa approved these changes

Reviewers whose approvals may not affect merge requirements
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uploader prefs miss {build.core.path}, {build.system.path} and {build.variant.path}
2 participants

AltStyle によって変換されたページ (->オリジナル) /