-
-
Notifications
You must be signed in to change notification settings - Fork 422
feat: allow to show compilation properties without providing a sketch #2089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@ ## master #2089 +/- ## ======================================= Coverage 35.01% 35.02% ======================================= Files 232 232 Lines 20560 20593 +33 ======================================= + Hits 7200 7213 +13 - Misses 12513 12535 +22 + Partials 847 845 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
ddaefa0 to
008ee78
Compare
715a41b to
7a3eefd
Compare
227c435 to
ff638bc
Compare
Actually, I don't think we need to go into the shenanigans of the builder anymore after #2082.
Probably we may also remove the "show properties" functionality from the legacy builder, but I need to try it.
I'll draft it in another PR so we can decide on the best approach.
Superseded by #2151
Please check if the PR fulfills these requirements
See how to contribute
Requests
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
Does this PR introduce a breaking change, and is titled accordingly?
Other information
Fixes #1047