Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

[skip-changelog] Migrate tests from test_compile_part_1.py to compile_part_1_test.go #1861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MatteoPologruto merged 11 commits into master from compile-test-go
Sep 26, 2022

Conversation

Copy link
Contributor

@MatteoPologruto MatteoPologruto commented Sep 2, 2022 •
edited
Loading

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)

What kind of change does this PR introduce?

Infrastructure Enhancement

What is the new behavior?

This PR is a followup to PR #1806
Integration tests that were previously present in test_compile_part_1.py have been rewritten in compile_part_1_test.go, without changing their original purpose.
The tests are the following:

  • TestCompileWithoutFqbn
  • TestCompileErrorMessage
  • TestCompileWithSimpleSketch
  • TestOutputFlagDefaultPath
  • TestCompileWithSketchWithSymlinkSelfloop
  • TestCompileBlacklistedSketchname
  • TestCompileWithoutPrecompiledLibraries
  • TestCompileWithBuildPropertiesFlag
  • TestCompileWithBuildPropertyContainingQuotes
  • TestCompileWithMultipleBuildPropertyFlags

Does this PR introduce a breaking change, and is titled accordingly?

No

See how to contribute

Copy link

codecov bot commented Sep 13, 2022 •
edited
Loading

Codecov Report

Base: 36.58% // Head: 36.60% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (356e5d9) compared to base (5730e2e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@ Coverage Diff @@
## master #1861 +/- ##
==========================================
+ Coverage 36.58% 36.60% +0.02% 
==========================================
 Files 231 231 
 Lines 19696 19698 +2 
==========================================
+ Hits 7206 7211 +5 
+ Misses 11659 11657 -2 
+ Partials 831 830 -1
Flag Coverage Δ
unit 36.60% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/integrationtest/arduino-cli.go 85.45% <100.00%> (+0.10%) ⬆️
arduino/cores/packagemanager/package_manager.go 66.58% <0.00%> (+0.75%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MatteoPologruto MatteoPologruto force-pushed the compile-test-go branch 3 times, most recently from 760eecd to 8f59212 Compare September 16, 2022 09:33 
test_compile_part_1.py to compile_part_1_test.go
...s runner
Long paths caused certain commands to fail on the Windows runner. Reducing their lengths prevents those errors from occurring.
Copy link
Contributor Author

Tests have been updated. They are now using the copy sketch function when necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 left review comments

@cmaglie cmaglie cmaglie approved these changes

@umbynos umbynos Awaiting requested review from umbynos

Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /