Commit 8c90790

committed

Migrated TestCompileWithBuildPropertyContainingQuotes from

test_compile_part_1.py to compile_part_1_test.go

1 parent 5512924 commit 8c90790Copy full SHA for 8c90790

File tree

2 files changed

+35

-25

lines changed

internal/integrationtest/compile
- compile_part_1_test.go
test
- test_compile_part_1.py

2 files changed

+35

-25

lines changed

`‎internal/integrationtest/compile/compile_part_1_test.go‎`

Lines changed: 35 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -380,3 +380,38 @@ func TestCompileWithBuildPropertiesFlag(t *testing.T) {`
`380`	`380`	`require.Contains(t, string(stdout), "-DFIRST_PIN=1")`
`381`	`381`	`require.Contains(t, string(stdout), "-DSECOND_PIN=2")`
`382`	`382`	`}`
	`383`	`+`
	`384`	`+func TestCompileWithBuildPropertyContainingQuotes(t *testing.T) {`
	`385`	`+ env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)`
	`386`	`+ defer env.CleanUp()`
	`387`	`+`
	`388`	`+ // Init the environment explicitly`
	`389`	`+ _, _, err := cli.Run("core", "update-index")`
	`390`	`+ require.NoError(t, err)`
	`391`	`+`
	`392`	`+ // Install Arduino AVR Boards`
	`393`	`+ _, _, err = cli.Run("core", "install", "arduino:avr@1.8.3")`
	`394`	`+ require.NoError(t, err)`
	`395`	`+`
	`396`	`+ // Copy sketch`
	`397`	`+ sketchName := "sketch_with_single_string_define"`
	`398`	`+ p, err := paths.Getwd()`
	`399`	`+ require.NoError(t, err)`
	`400`	`+ require.NotNil(t, p)`
	`401`	`+ testSketch := p.Parent().Join("testdata", sketchName)`
	`402`	`+ sketchPath := cli.SketchbookDir().Join(sketchName)`
	`403`	`+ err = testSketch.CopyDirTo(sketchPath)`
	`404`	`+ require.NoError(t, err)`
	`405`	`+`
	`406`	`+ fqbn := "arduino:avr:uno"`
	`407`	`+`
	`408`	`+ // Compile using a build property with quotes`
	`409`	`+ stdout, _, err := cli.Run("compile",`
	`410`	`+ "-b",`
	`411`	`+ fqbn,`
	`412`	+ `--build-property=build.extra_flags="-DMY_DEFINE="hello world""`,
	`413`	`+ sketchPath.String(),`
	`414`	`+ "--verbose")`
	`415`	`+ require.NoError(t, err)`
	`416`	+ require.Contains(t, string(stdout), `-DMY_DEFINE=\"hello world\"`)
	`417`	`+}`

`‎test/test_compile_part_1.py‎`

Lines changed: 0 additions & 25 deletions

Original file line number	Diff line number	Diff line change
`@@ -60,31 +60,6 @@ def test_compile_without_precompiled_libraries(run_command, data_dir):`
`60`	`60`	`assert run_command(["compile", "-b", "arduino:samd:mkrvidor4000", sketch_path])`
`61`	`61`
`62`	`62`
`63`		`-def test_compile_with_build_property_containing_quotes(run_command, data_dir, copy_sketch):`
`64`		`- # Init the environment explicitly`
`65`		`- assert run_command(["core", "update-index"])`
`66`		`-`
`67`		`- # Install Arduino AVR Boards`
`68`		`- assert run_command(["core", "install", "arduino:avr@1.8.3"])`
`69`		`-`
`70`		`- sketch_path = copy_sketch("sketch_with_single_string_define")`
`71`		`- fqbn = "arduino:avr:uno"`
`72`		`-`
`73`		`- # Compile using a build property with quotes`
`74`		`- res = run_command(`
`75`		`- [`
`76`		`- "compile",`
`77`		`- "-b",`
`78`		`- fqbn,`
`79`		`- '--build-property=build.extra_flags=\\"-DMY_DEFINE=\\"hello world\\"\\"',`
`80`		`- sketch_path,`
`81`		`- "--verbose",`
`82`		`- ]`
`83`		`- )`
`84`		`- assert res.ok`
`85`		`- assert '-DMY_DEFINE=\\"hello world\\"' in res.stdout`
`86`		`-`
`87`		`-`
`88`	`63`	`def test_compile_with_multiple_build_property_flags(run_command, data_dir, copy_sketch, working_dir):`
`89`	`64`	`# Init the environment explicitly`
`90`	`65`	`assert run_command(["core", "update-index"])`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit 8c90790

File tree

2 files changed

2 files changed

`‎internal/integrationtest/compile/compile_part_1_test.go‎`

`‎test/test_compile_part_1.py‎`

0 commit comments