Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

[skip-changelog] Migrate tests from test_board.py to board_test.go #1847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MatteoPologruto merged 11 commits into master from board-test-go
Oct 11, 2022

Conversation

Copy link
Contributor

@MatteoPologruto MatteoPologruto commented Aug 24, 2022 •
edited
Loading

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)

What kind of change does this PR introduce?

Infrastructure enhancement

What is the new behavior?

This PR is a followup to PR #1806
Integration tests that were previously present in test_board.py have been rewritten in board_test.go, without changing their original purpose.
The tests are the following:

  • TestBoardList
  • TestBoardListWithInvalidDiscovery
  • TestBoardListall
  • TestBoardListallWithManuallyInstalledPlatform
  • TestBoardDetails
  • TestBoardDetailsNoFlags
  • TestBoardDetailsListProgrammersWithouthFlags
  • TestBoardDetailsListProgrammersFlags
  • TestBoardSearch
  • TestBoardAttachWithoutSketchJson
  • TestBoardSearchWithOutdatedCore

Does this PR introduce a breaking change, and is
titled accordingly?

No

See how to contribute

@MatteoPologruto MatteoPologruto added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure labels Aug 24, 2022
Copy link

codecov bot commented Aug 24, 2022 •
edited
Loading

Codecov Report

Base: 36.65% // Head: 36.69% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (9967f32) compared to base (2480d93).
Patch has no changes to coverable lines.

❗ Current head 9967f32 differs from pull request most recent head 448a41b. Consider uploading reports for the commit 448a41b to get more accurate results

Additional details and impacted files 
@@ Coverage Diff @@
## master #1847 +/- ##
==========================================
+ Coverage 36.65% 36.69% +0.04% 
==========================================
 Files 231 231 
 Lines 19683 19699 +16 
==========================================
+ Hits 7215 7229 +14 
+ Misses 11640 11639 -1 
- Partials 828 831 +3
Flag Coverage Δ
unit 36.69% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
arduino/monitor/monitor.go 41.05% <0.00%> (-4.74%) ⬇️
commands/instances.go 40.04% <0.00%> (+0.40%) ⬆️
arduino/cores/packagemanager/package_manager.go 66.58% <0.00%> (+0.75%) ⬆️
arduino/resources/index.go 52.57% <0.00%> (+12.37%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@cmaglie cmaglie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO we can dramatically improve readability through the use of requirejson let's have a chat about it.

@MatteoPologruto MatteoPologruto force-pushed the board-test-go branch 3 times, most recently from 673d236 to 4d0ddac Compare September 13, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmaglie cmaglie cmaglie approved these changes

@umbynos umbynos Awaiting requested review from umbynos

Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /