Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit 962591f

Browse files
Migrated TestBoardSearchWithOutdatedCore to board_test.go and deleted test_board.py
1 parent ab6160e commit 962591f

File tree

2 files changed

+32
-44
lines changed

2 files changed

+32
-44
lines changed

‎internal/integrationtest/board/board_test.go‎

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,14 @@
1616
package board_test
1717

1818
import (
19+
"encoding/json"
1920
"os"
2021
"strings"
2122
"testing"
2223

2324
"github.com/arduino/arduino-cli/internal/integrationtest"
2425
"github.com/stretchr/testify/require"
26+
semver "go.bug.st/relaxed-semver"
2527
"go.bug.st/testifyjson/requirejson"
2628
"gopkg.in/src-d/go-git.v4"
2729
"gopkg.in/src-d/go-git.v4/plumbing"
@@ -449,3 +451,33 @@ func TestBoardAttachWithoutSketchJson(t *testing.T) {
449451
_, _, err = cli.Run("board", "attach", "-b", fqbn, sketchPath.String())
450452
require.NoError(t, err)
451453
}
454+
455+
func TestBoardSearchWithOutdatedCore(t *testing.T) {
456+
env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
457+
defer env.CleanUp()
458+
459+
_, _, err := cli.Run("update")
460+
require.NoError(t, err)
461+
462+
// Install an old core version
463+
_, _, err = cli.Run("core", "install", "arduino:samd@1.8.6")
464+
require.NoError(t, err)
465+
466+
stdout, _, err := cli.Run("board", "search", "arduino:samd:mkrwifi1010", "--format", "json")
467+
require.NoError(t, err)
468+
requirejson.Len(t, stdout, 1)
469+
var data []map[string]interface{}
470+
err = json.Unmarshal(stdout, &data)
471+
require.NoError(t, err)
472+
board := data[0]
473+
require.Equal(t, board["name"], "Arduino MKR WiFi 1010")
474+
require.Equal(t, board["fqbn"], "arduino:samd:mkrwifi1010")
475+
samdCore := board["platform"].(map[string]interface{})
476+
require.Equal(t, samdCore["id"], "arduino:samd")
477+
installedVersion, err := semver.Parse(samdCore["installed"].(string))
478+
require.NoError(t, err)
479+
latestVersion, err := semver.Parse(samdCore["latest"].(string))
480+
require.NoError(t, err)
481+
// Installed version must be older than latest
482+
require.True(t, installedVersion.LessThan(latestVersion))
483+
}

‎test/test_board.py‎

Lines changed: 0 additions & 44 deletions
This file was deleted.

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /