-
Notifications
You must be signed in to change notification settings - Fork 7
[CLI] Add a "restart" app command #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lucarin91
commented
Oct 30, 2025
This is needed only for the CLI interface.
I think we could also implement the endpoint. I could also find this useful for the FE, maybe in another PR
@mirkoCrobu
mirkoCrobu
changed the title
(削除) add restart cli command (削除ここまで)
(追記) [CLI] Add a "restart" app command (追記ここまで)
Oct 30, 2025
Contributor
Author
mirkoCrobu
commented
Oct 30, 2025
I created the issue: https://github.com/bcmi-labs/orchestrator/issues/814
lucarin91
lucarin91
requested changes
Oct 31, 2025
Contributor
@lucarin91
lucarin91
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You miss the check that the app running is the one you are trying to restart
@mirkoCrobu
mirkoCrobu
force-pushed
the
issue_552_restart_cli_command
branch
from
November 3, 2025 16:01
90b0173 to
2fa49cc
Compare
lucarin91
lucarin91
approved these changes
Nov 3, 2025
mirkoCrobu
added a commit
that referenced
this pull request
Nov 4, 2025
The CLI provides a command to start and stop an app/example. Often it's useful to have a restart command, that will stop and start again the same app. This is needed only for the CLI interface. The command already exists. But error management should be improved: restarting an app X when app Y is running does not show a clear error if the app running is not the one being restarted: error if no app is running: just start the app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Motivation
The CLI provides a command to start and stop an app/example. Often it's useful to have a restart command, that will stop and start again the same app. This is needed only for the CLI interface.
The command already exists. But error management should be improved:
Change description
Additional Notes
Tested on board, arduino-app-cli v.365
Reviewer checklist
main.