Commit 90b0173

mirkoCrobumirkoCrobu

mirkoCrobu

authored and

mirkoCrobu

committed

code review feedback

1 parent 40eca71 commit 90b0173Copy full SHA for 90b0173

File tree

-8

lines changed

-8

lines changed

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,6 @@ func restartHandler(ctx context.Context, cfg config.Configuration, app app.Ardui`
`77`	`77`	`}`
`78`	`78`	`}`
`79`	`79`
`80`		`- // Feedback finale di successo`
`81`	`80`	`outputResult := getResult()`
`82`	`81`	`feedback.PrintResult(restartAppResult{`
`83`	`82`	`AppName: app.Name,`

Lines changed: 7 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -451,11 +451,16 @@ func RestartApp(`
`451`	`451`	`yield(StreamMessage{error: err})`
`452`	`452`	`return`
`453`	`453`	`}`
	`454`	`+`
	`455`	`+ if runningApp != nil && runningApp.FullPath.String() != appToStart.FullPath.String() {`
	`456`	`+ yield(StreamMessage{error: fmt.Errorf("another app %q is running", runningApp.Name)})`
	`457`	`+ return`
	`458`	`+ }`
	`459`	`+`
`454`	`460`	`if runningApp != nil {`
`455`	`461`	`stopStream := StopApp(ctx, *runningApp)`
`456`	`462`	`for msg := range stopStream {`
`457`	`463`	`if !yield(msg) {`
`458`		`- cancel()`
`459`	`464`	`return`
`460`	`465`	`}`
`461`	`466`	`if msg.error != nil {`
`@@ -464,12 +469,7 @@ func RestartApp(`
`464`	`469`	`}`
`465`	`470`	`}`
`466`	`471`	`startStream := StartApp(ctx, docker, provisioner, modelsIndex, bricksIndex, appToStart, cfg, staticStore)`
`467`		`- for msg := range startStream {`
`468`		`- if !yield(msg) {`
`469`		`- cancel()`
`470`		`- return`
`471`		`- }`
`472`		`- }`
	`472`	`+ startStream(yield)`
`473`	`473`	`}`
`474`	`474`	`}`
`475`	`475`

Comments

(0)