-
-
Notifications
You must be signed in to change notification settings - Fork 140
Add SPI bus mode support (controller/peripheral) #257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@facchinm
facchinm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I'd just add a comment stating the the "downstream" platforms should add a define (eg. SPI_HAS_PERIPHERAL_MODE) in case they support the functionality
c86ff82 to
aa6b22b
Compare
iabdalkader
commented
Sep 29, 2025
add a comment stating the the "downstream" platforms should add a define (eg.
SPI_HAS_PERIPHERAL_MODE) in case they support the functionality
Updated.
api/HardwareSPI.h
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove the eg to make the define official :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Signed-off-by: iabdalkader <i.abdalkader@gmail.com>
aa6b22b to
dab7773
Compare
No description provided.