Avoid copying whole directory on Open in all cases #7909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

facchinm wants to merge 1 commit into arduino:master

from facchinm:copy_directory_on_open_only_if_needed_master

Open

Avoid copying whole directory on Open in all cases #7909

facchinm wants to merge 1 commit into arduino:master from facchinm:copy_directory_on_open_only_if_needed_master

Conversation

facchinm

Copy link

Member

@facchinm facchinm commented Aug 22, 2018 •

edited

Loading

Alternative to #7904, tries to distinguish between

click on a single ino file downloaded from the internet (old behaviour applies, directory is created and the file is moved in it)
click on an ino file that for some reason is part of a project with the wrong name (eg. it was downloaded as zip from github, so the containing folder names becomes "projectName-master"). In this case if the directory is renamed after prompting the user)
2018年08月22日-112348_1920x1080_scrot

@facchinm facchinm requested a review from cmaglie

August 22, 2018 08:24

@facchinm facchinm force-pushed the copy_directory_on_open_only_if_needed_master branch from 38151d6 to 54adc00 Compare

August 22, 2018 09:39

@arduino arduino deleted a comment from ArduinoBot

Aug 22, 2018

@arduino arduino deleted a comment from ArduinoBot

Aug 22, 2018

This was referenced Aug 23, 2018

Moving a sketch to another folder should move all files #6404

Closed

Avoid performing non trivial operations on files #7904

Closed

@facchinm facchinm added this to the Release 1.8.7 milestone

Aug 27, 2018

@facchinm facchinm modified the milestones: Release 1.8.7, Release 1.8.8

Sep 17, 2018

@sandeepmistry

Copy link

Contributor

sandeepmistry commented Sep 17, 2019

@facchinm are we still interested in moving ahead with these changes?

@facchinm

Copy link

Member Author

facchinm commented Sep 18, 2019

Yes, since the behaviour as of today is wrong 🙂
But maybe the right place to apply this would be the cli (if it enforces the dirName/dirName.ino convention)

@facchinm


 Rename sketch folder only if proper name is slightly different

3e3593d

Takes into account Github-like transformations (projectName becomes projectName-branchName)
Also changes user prompt to specify that it will move a whole folder.